From: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: kexec-ml <kexec@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH-v2] kdump: Enable kdump if 2nd-kernel is loaded.
Date: Mon, 13 Jul 2009 13:33:07 +0900 [thread overview]
Message-ID: <4A5AB903.6090204@mxs.nes.nec.co.jp> (raw)
In-Reply-To: <4A56E069.5040907@jp.fujitsu.com>
Hi,
This patch is a new version by Seto-san's comment.
Changelog since v1:
* Remove the check code other than kexec_crash_image from kexec_should_crash()
because a kexec cannot crash if there is no image.
This patch enables a kdump if 2nd-kernel is loaded.
(The patch is based on linux-2.6.31-rc2.)
Now, a kdump on oops is enabled if a kernel parameter "oops=panic"
is specified and 2nd-kernel is loaded. I think that a kdump should
be enabled regardless of "oops=panic" if 2nd-kernel is loaded,
because a system administrator loads 2nd-kernel for enabling a kdump.
* Reference
The discussion about this patch
http://lists.infradead.org/pipermail/kexec/2009-July/003417.html
http://lists.infradead.org/pipermail/kexec/2009-July/003433.html
Thanks
Ken'ichi Ohmichi
Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Acked-by: Simon Horman <horms@verge.net.au>
---
--- a/kernel/kexec.c 2009-07-08 12:30:26.000000000 +0900
+++ b/kernel/kexec.c 2009-07-13 13:49:03.000000000 +0900
@@ -57,7 +57,7 @@ struct resource crashk_res = {
int kexec_should_crash(struct task_struct *p)
{
- if (in_interrupt() || !p->pid || is_global_init(p) || panic_on_oops)
+ if (kexec_crash_image)
return 1;
return 0;
}
next prev parent reply other threads:[~2009-07-13 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-09 8:05 [PATCH] " Ken'ichi Ohmichi
2009-07-10 6:32 ` Hidetoshi Seto
2009-07-10 7:05 ` Ken'ichi Ohmichi
2009-07-10 7:52 ` Hidetoshi Seto
2009-07-13 4:33 ` Ken'ichi Ohmichi [this message]
2009-07-13 7:48 ` [PATCH-v2] " Hidetoshi Seto
2009-07-13 17:06 ` Eric W. Biederman
2009-07-14 2:04 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5AB903.6090204@mxs.nes.nec.co.jp \
--to=oomichi@mxs.nes.nec.co.jp \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®