From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: dedekind@infradead.org
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>,
linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Sachin P Sant <sachinp@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Date: Thu, 16 Jul 2009 13:57:36 +0200 [thread overview]
Message-ID: <4A5F15B0.9030100@s5r6.in-berlin.de> (raw)
In-Reply-To: <4A5F0F03.5080507@s5r6.in-berlin.de>
Stefan Richter wrote:
> So, is uninitialized_var() a good fix here? I'd say it's not a
> particular good one. Count the lines of code of dbg_check_old_index()
> and the maximum indentation level of it. Then remember the teachings of
> CodingStyle. :-) See? dbg_check_old_index() clearly isn't a prime
> example of best kernel coding practice. /Perhaps/ a little bit of
> refactoring would make it easier to read, and as a bonus side effect,
> make it unnecessary to use the slightly dangerous and
> uninitialized_var() macro here.
PS:
On the other hand, it is debug code. Is it bound to stay in there
forever? If not, then it's surely not worth the developer time to
beautify it.
--
Stefan Richter
-=====-==--= -=== =----
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-07-16 11:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 2:19 Subrata Modak
2009-07-15 6:52 ` Artem Bityutskiy
2009-07-15 18:16 ` Stefan Richter
2009-07-16 9:57 ` Artem Bityutskiy
2009-07-16 11:04 ` Subrata Modak
2009-07-16 11:12 ` Artem Bityutskiy
2009-07-16 11:21 ` Subrata Modak
2009-07-16 11:46 ` Stefan Richter
2009-07-16 11:29 ` Stefan Richter
2009-07-16 11:57 ` Stefan Richter [this message]
2009-07-16 12:11 ` Artem Bityutskiy
2009-07-16 12:09 ` Artem Bityutskiy
2009-07-16 12:41 Subrata Modak
2009-07-16 12:54 ` Artem Bityutskiy
2009-07-16 13:10 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5F15B0.9030100@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=adrian.hunter@nokia.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dedekind@infradead.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=sachinp@linux.vnet.ibm.com \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®