From: "Jan Beulich" <JBeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] i386: fix double accounting in reserve_top_address()
Date: Thu, 30 Jul 2009 16:49:30 +0100 [thread overview]
Message-ID: <4A71DD2A020000780000D482@vpn.id2.novell.com> (raw)
With VMALLOC_END included in the calculation of MAXMEM (as of 2.6.28)
it is no longer correct to also bump __VMALLOC_RESERVE in
reserve_top_address(). Doing so results in needlessly small lowmem.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/mm/pgtable.c | 1 -
1 file changed, 1 deletion(-)
--- linux-2.6.31-rc4/arch/x86/mm/pgtable.c 2009-07-28 09:36:41.000000000 +0200
+++ 2.6.31-rc4-i386-reserve-top-address/arch/x86/mm/pgtable.c 2009-07-30 17:27:52.000000000 +0200
@@ -329,7 +329,6 @@ void __init reserve_top_address(unsigned
printk(KERN_INFO "Reserving virtual address space above 0x%08x\n",
(int)-reserve);
__FIXADDR_TOP = -reserve - PAGE_SIZE;
- __VMALLOC_RESERVE += reserve;
#endif
}
next reply other threads:[~2009-07-30 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 15:49 Jan Beulich [this message]
2009-08-04 15:32 ` [tip:x86/urgent] x86, 32-bit: Fix " tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A71DD2A020000780000D482@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®