From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934198AbZHEOCm (ORCPT ); Wed, 5 Aug 2009 10:02:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933568AbZHEOCm (ORCPT ); Wed, 5 Aug 2009 10:02:42 -0400 Received: from mail.mnementh.co.uk ([173.45.232.4]:38470 "EHLO mnementh.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933520AbZHEOCl (ORCPT ); Wed, 5 Aug 2009 10:02:41 -0400 Message-ID: <4A7990F6.7030701@mnementh.co.uk> Date: Wed, 05 Aug 2009 15:02:30 +0100 From: Ian Molton User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Magnus Damm CC: Guennadi Liakhovetski , pHilipp Zabel , Paul Mundt , Mark Brown , linux-kernel@vger.kernel.org, Pierre Ossman , Magnus Damm Subject: Example idea for how to solve the clock/cnf problem. References: <4A7053E8.8050303@mnementh.co.uk> <20090729201702.GA28202@linux-sh.org> <74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com> <4A716F1C.2050805@mnementh.co.uk> <4A71F2A5.4060206@mnementh.co.uk> <4A787C2C.5070000@mnementh.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi folks, I've spent a little time hacking on the code this afternoon, here is a WIP that completely removes cnf area accesses from the mmc driver. These are now pushed out into the platform / MFD level code. I've taken TC6393XB as an example and pushed the CNF code into that. I imagine that several chips can share that code so I will break it out into another file, mfd/tmio_common.c, probably. This code probably doesnt compile yet, but should give some idea about how I think this should be done. How are other devices setting the card clock? are they using my clock setup function? If so, then we are probably best off avoiding the clock API for the card clock, as getting the full range of frequencies require access to both CNF and CTL areas on TMIO MFDs. If not, then we will need to do more thinking.