On 08/13/2009 07:06 PM, Wang, Shane wrote:
> I agree with hpa, considering TXT doesnot depends on acpi sleep.
> 
> takes effect but tboot->mac_regions[] will never be used without S3.
> 

Given that, I would create a function called tboot_setup_suspend() or
something like that and localize the setting of mac_regions as well as
s3_resume_vector there.

Since it looks like s3_resume_vector is simply set up in tboot_sleep()
before we'd call tboot_shutdown(), we can presumably simply do it all in
tboot_shutdown().

Ingo, Shane: how does the attached patch look?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.