From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbZHPCtn (ORCPT ); Sat, 15 Aug 2009 22:49:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753725AbZHPCtm (ORCPT ); Sat, 15 Aug 2009 22:49:42 -0400 Received: from rtr.ca ([76.10.145.34]:34129 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700AbZHPCtl (ORCPT ); Sat, 15 Aug 2009 22:49:41 -0400 Message-ID: <4A8773C4.6030409@rtr.ca> Date: Sat, 15 Aug 2009 22:49:40 -0400 From: Mark Lord Organization: Real-Time Remedies Inc. User-Agent: Thunderbird 2.0.0.22 (X11/20090608) MIME-Version: 1.0 To: Christoph Hellwig Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jens.axboe@oracle.com Subject: Re: [PATCH, RFC] xfs: batched discard support References: <20090816004705.GA7347@infradead.org> <4A876255.10606@rtr.ca> <4A876CA9.20906@rtr.ca> <20090816022500.GA12392@infradead.org> In-Reply-To: <20090816022500.GA12392@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: > On Sat, Aug 15, 2009 at 10:19:21PM -0400, Mark Lord wrote: >> Mark Lord wrote: >>> Christoph Hellwig wrote: >> .. >>>> Mark, any chance to try it? Just create an XFS filesystem, age it a >>>> bit and then call the attached little trim.c program on the mountmoint >>>> (or any file inside the filesystem for that matter) >>> .. >>> >>> Looking at it now. Thanks, Christoph! >> .. >> >> Fails to work on 64-bit kernel w/ 32-bit userspace (no compat ioctl). >> Rebuilding with 32-bit kernel now.. > > The actual ioctl is compatible, just add the > > case XFS_IOC_TRIM: > return xfs_ioc_trim(mp, arg); > > to xfs_file_compat_ioctl(). I'll add this to the next spin of the patch. .. Peachy. Rebuilding again now.. Don't wait up for this .. I'll finish it on Sunday. Bedtime. :)