mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: pageexec@freemail.hu
Cc: linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/6] firewire: ohci: fix Self ID Count register mask (safeguard against buffer overflow)
Date: Mon, 07 Sep 2009 21:28:37 +0200	[thread overview]
Message-ID: <4AA55EE5.10102@s5r6.in-berlin.de> (raw)
In-Reply-To: <4AA5575E.6620.3D14E038@pageexec.freemail.hu>

pageexec@freemail.hu wrote:
> On 6 Sep 2009 at 18:49, Stefan Richter wrote:
> 
> added stable as .30 is affected, possibly older kernels as well, i didn't check.

The mistake which is fixed here is present since firewire-ohci was added 
in 2.6.22.  However, for a smooth submission to stable, the patched file...

>> --- linux-2.6.31-rc9.orig/drivers/firewire/ohci.c
>> +++ linux-2.6.31-rc9/drivers/firewire/ohci.c

...has to be drivers/firewire/fw-ohci.c in kernels before 2.6.31-rc1.

As hinted at in the changelog, I personally don't consider the fix 
urgent because there are a few more self ID consistency checks in place 
which catch a variety of real and theoretical corruptions, but I don't 
claim that I'm appropriately aware of all possibilities.
-- 
Stefan Richter
-=====-==--= =--= --===
http://arcgraph.de/sr/

  reply	other threads:[~2009-09-07 19:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-06 16:46 [PATCH 0/6] firewire: minor fixes and cleanups Stefan Richter
2009-09-06 16:48 ` [PATCH 1/6] firewire: core: reduce stack usage in bus reset tasklet Stefan Richter
2009-09-07 19:02   ` pageexec
2009-09-07 19:15     ` Stefan Richter
2009-09-07 21:24       ` Stefan Richter
2009-09-06 16:49 ` [PATCH 2/6] firewire: ohci: fix Self ID Count register mask (safeguard against buffer overflow) Stefan Richter
2009-09-07 18:56   ` pageexec
2009-09-07 19:28     ` Stefan Richter [this message]
2009-09-06 16:49 ` [PATCH 3/6] firewire: core: header file cleanup Stefan Richter
2009-09-06 16:50 ` [PATCH 4/6] firewire: core: fix race with parallel PCI device probe Stefan Richter
2009-09-06 16:50 ` [PATCH 5/6] firewire: reduce some memsets Stefan Richter
2009-09-06 16:51 ` [PATCH 6/6] firewire: sbp2: fix status reception Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA55EE5.10102@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=pageexec@freemail.hu \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®