From: "H. Peter Anvin" <hpa@zytor.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Michal Hocko <mhocko@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4] x86: increase MIN_GAP to include randomized stack
Date: Thu, 10 Sep 2009 16:29:02 -0700 [thread overview]
Message-ID: <4AA98BBE.20407@zytor.com> (raw)
In-Reply-To: <alpine.LNX.2.00.0909110112470.23856@wotan.suse.de>
On 09/10/2009 04:14 PM, Jiri Kosina wrote:
> On Tue, 8 Sep 2009, Jiri Kosina wrote:
>
>>> Currently we are not including randomized stack size when calculating
>>> mmap_base address in arch_pick_mmap_layout for topdown case. This might
>>> cause that mmap_base starts in the stack reserved area because stack is
>>> randomized by 1GB for 64b (8MB for 32b) and the minimum gap is 128MB.
>>>
>>> If the stack really grows down to mmap_base then we can get silent mmap
>>> region overwrite by the stack values.
>>>
>>> Let's include maximum stack randomization size into MIN_GAP which is
>>> used as the low bound for the gap in mmap.
>>>
>>> Signed-off-by: Michal Hocko <mhocko@suse.cz>
>>
>> Acked-by: Jiri Kosina <jkosina@suse.cz>
>>
>> Ingo, could you please consider applying this?
>
> Any comments about this patch please? (aka. "ping") :)
>
Looks right to me... I'll apply it and see how it does.
-hpa
next prev parent reply other threads:[~2009-09-10 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 9:37 [PATCH v2] " Michal Hocko
2009-09-07 8:28 ` Michal Hocko
2009-09-07 15:18 ` Jiri Kosina
2009-09-08 7:32 ` Michal Hocko
2009-09-08 8:43 ` [PATCH v3] " Michal Hocko
2009-09-08 8:47 ` Jiri Kosina
2009-09-08 8:53 ` Michal Hocko
2009-09-08 9:01 ` [PATCH v4] " Michal Hocko
2009-09-08 9:09 ` Jiri Kosina
2009-09-10 23:14 ` Jiri Kosina
2009-09-10 23:29 ` H. Peter Anvin [this message]
2009-09-11 0:06 ` [tip:x86/urgent] x86: Increase " tip-bot for Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA98BBE.20407@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®