mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
	uclinux-dev@uclinux.org
Subject: Re: free_initrd_mem() corrups mm state on m68knommu.
Date: Fri, 18 Sep 2009 09:42:59 +1000	[thread overview]
Message-ID: <4AB2C983.3000808@snapgear.com> (raw)
In-Reply-To: <20090917151908.GW23700@csclub.uwaterloo.ca>

Hi Lennart,

Lennart Sorensen wrote:
> On Thu, Sep 17, 2009 at 05:34:37PM +1000, Greg Ungerer wrote:
>> Hi Lennart,
>>
>> Lennart Sorensen wrote:
>>> On Tue, Sep 15, 2009 at 05:49:59PM -0400, Lennart Sorensen wrote:
...
>>> OK, seems the issue was that setup.c wasn't flagging the initrd memory
>>> range as 'reserve_bootmem' which caused extra memory to be forced into
>>> the mm state when it was later freed.  I guess one has to be very careful
>>> with what patches one finds lying around the internet (in this case the
>>> uboot bootargs patch for m68knommu that we found somewhere).
>>>
>>> Seems to work great now, and I finally made sense of how the bootmem
>>> map is passed and what is going where.  It all makes sense now.
>> Can you send a patch for it?
>> I can push it to mainline of it looks reasonable.
> 
> Well it's a patch ontop of another patch that isn't in mainline.
> The other patch is one that adds support for uboot passing kernel command
> line arguments.  Want that one too?  We find it to be rather useful.

Sure, send them both.

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

  reply	other threads:[~2009-09-17 23:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 21:49 Lennart Sorensen
2009-09-16 15:45 ` Lennart Sorensen
2009-09-17  7:34   ` Greg Ungerer
2009-09-17 15:19     ` Lennart Sorensen
2009-09-17 23:42       ` Greg Ungerer [this message]
2009-09-18 16:28         ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AB2C983.3000808@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome