From: Peter Williams <pwil3058@bigpond.net.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: sched: Am I missing something?
Date: Mon, 21 Sep 2009 23:22:41 +1000 [thread overview]
Message-ID: <4AB77E21.6020805@bigpond.net.au> (raw)
Or is the line:
p->prio = effective_prio(p);
in wake_up_new_task() an expensive no op.
As far as I can tell from reading the code, it will always be the case
that EITHER rt_prio(p->prio) is true OR p->prio == p->normal_prio when
this call is made and, in either case, the value of p->prio will be
unchanged. In addition, when this call is made p->normal_prio is
already equal to to normal_prio(p), so the side effects of the function
(setting p->normal_prio) are also unnecessary.
Am I correct or have I missed something?
Peter
--
Peter Williams pwil3058@bigpond.net.au
"Learning, n. The kind of ignorance distinguishing the studious."
-- Ambrose Bierce
next reply other threads:[~2009-09-21 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 13:22 Peter Williams [this message]
2009-09-21 13:53 ` Peter Zijlstra
2009-09-21 23:53 ` Peter Williams
2009-09-23 14:36 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB77E21.6020805@bigpond.net.au \
--to=pwil3058@bigpond.net.au \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®