From: Roger Quadros <ext-roger.quadros@nokia.com>
To: "dedekind1@gmail.com" <dedekind1@gmail.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"tony@atomide.com" <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] twl4030: Fix boot with twl4030 usb transceiver enabled
Date: Thu, 01 Oct 2009 11:41:04 +0300 [thread overview]
Message-ID: <4AC46B20.6020300@nokia.com> (raw)
In-Reply-To: <1254386189.32310.20.camel@localhost>
Artem Bityutskiy wrote:
> On Thu, 2009-10-01 at 11:25 +0300, Roger Quadros wrote:
>> if (twl_has_bci() && pdata->bci && !(features & TPS_SUBSET)) {
>> child = add_child(3, "twl4030_bci",
>> @@ -532,16 +531,61 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
>> }
>>
>> if (twl_has_usb() && pdata->usb) {
>> +
> Why is this extra line?
>
>> + static struct regulator_consumer_supply usb1v5 = {
>> + .supply = "usb1v5",
>> + };
>
oops, my bad. and checkpatch didn't point it out ;)
next prev parent reply other threads:[~2009-10-01 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 8:25 Roger Quadros
2009-10-01 8:36 ` Artem Bityutskiy
2009-10-01 8:41 ` Roger Quadros [this message]
2009-10-09 12:32 ` Roger Quadros
2009-10-09 15:55 ` Roger Quadros
2009-10-09 16:14 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC46B20.6020300@nokia.com \
--to=ext-roger.quadros@nokia.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome