From: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Eric Paris <eparis@redhat.com>,
Dustin Kirkland <kirkland@canonical.com>,
James Morris <jmorris@namei.org>,
David Safford <safford@watson.ibm.com>,
stable@kernel.org, Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH] ima: ecryptfs fix imbalance message (updated)
Date: Tue, 06 Oct 2009 17:18:55 -0500 [thread overview]
Message-ID: <4ACBC24F.2040005@linux.vnet.ibm.com> (raw)
In-Reply-To: <1254767144-4756-1-git-send-email-zohar@linux.vnet.ibm.com>
On 10/05/2009 01:25 PM, Mimi Zohar wrote:
> The unencrypted files are being measured. Update the counters to get
> rid of the ecryptfs imbalance message. (http://bugzilla.redhat.com/519737)
>
> Reported-by: Sachin Garg
> Cc: stable@kernel.org
> Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> ---
> fs/ecryptfs/main.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 101fe4c..c6ac85d 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -35,6 +35,7 @@
> #include <linux/key.h>
> #include <linux/parser.h>
> #include <linux/fs_stack.h>
> +#include <linux/ima.h>
> #include "ecryptfs_kernel.h"
>
> /**
> @@ -118,6 +119,7 @@ int ecryptfs_init_persistent_file(struct dentry *ecryptfs_dentry)
> const struct cred *cred = current_cred();
> struct ecryptfs_inode_info *inode_info =
> ecryptfs_inode_to_private(ecryptfs_dentry->d_inode);
> + int opened_lower_file = 0;
> int rc = 0;
>
> mutex_lock(&inode_info->lower_file_mutex);
> @@ -134,9 +136,12 @@ int ecryptfs_init_persistent_file(struct dentry *ecryptfs_dentry)
> "for lower_dentry [0x%p] and lower_mnt [0x%p]; "
> "rc = [%d]\n", lower_dentry, lower_mnt, rc);
> inode_info->lower_file = NULL;
> - }
> + } else
> + opened_lower_file = 1;
> }
> mutex_unlock(&inode_info->lower_file_mutex);
> + if (opened_lower_file)
> + ima_counts_get(inode_info->lower_file);
> return rc;
> }
>
Hi Mimi - Thanks for the updated patch!
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/ecryptfs/ecryptfs-2.6.git#next
Tyler
prev parent reply other threads:[~2009-10-06 22:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 18:25 Mimi Zohar
2009-10-06 22:18 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACBC24F.2040005@linux.vnet.ibm.com \
--to=tyhicks@linux.vnet.ibm.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=kirkland@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=safford@watson.ibm.com \
--cc=stable@kernel.org \
--cc=zohar@linux.vnet.ibm.com \
--cc=zohar@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome