From: Rik van Riel <riel@redhat.com>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
venkatesh.pallipadi@intel.com, greg@kroah.com, riel@redhat.com,
steven@uplinklabs.net, ext-eero.nurkkala@nokia.com,
tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] NOHZ: update idle state also when NOHZ is inactive
Date: Wed, 07 Oct 2009 09:35:43 -0400 [thread overview]
Message-ID: <4ACC992F.3060001@redhat.com> (raw)
In-Reply-To: <tip-fdc6f192e7e1ae80565af23cc33dc88e3dcdf184@git.kernel.org>
tip-bot for Eero Nurkkala wrote:
> Commit-ID: fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Gitweb: http://git.kernel.org/tip/fdc6f192e7e1ae80565af23cc33dc88e3dcdf184
> Author: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
> AuthorDate: Wed, 7 Oct 2009 11:54:26 +0300
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 7 Oct 2009 13:05:05 +0200
>
> NOHZ: update idle state also when NOHZ is inactive
>
> Commit f2e21c9610991e95621a81407cdbab881226419b had unfortunate side
> effects with cpufreq governors on some systems.
>
> If the system did not switch into NOHZ mode ts->inidle is not set when
> tick_nohz_stop_sched_tick() is called from the idle routine. Therefor
> all subsequent calls from irq_exit() to tick_nohz_stop_sched_tick()
> fail to call tick_nohz_start_idle(). This results in bogus idle
> accounting information which is passed to cpufreq governors.
>
> Set the inidle flag unconditionally of the NOHZ active state to keep
> the idle time accounting correct in any case.
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
prev parent reply other threads:[~2009-10-07 13:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 16:32 [BISECTED] "conservative" cpufreq governor broken Steven Noonan
2009-10-06 7:31 ` Eero Nurkkala
2009-10-06 10:22 ` Steven Noonan
2009-10-06 10:43 ` Eero Nurkkala
2009-10-06 11:22 ` Steven Noonan
2009-10-06 12:36 ` Eero Nurkkala
2009-10-07 0:54 ` Steven Noonan
2009-10-07 1:22 ` Steven Noonan
2009-10-07 5:27 ` Eero Nurkkala
2009-10-07 7:30 ` Steven Noonan
2009-10-07 7:49 ` Eero Nurkkala
2009-10-07 8:05 ` Steven Noonan
2009-10-07 8:11 ` Steven Noonan
2009-10-07 8:14 ` Eero Nurkkala
2009-10-07 8:24 ` Steven Noonan
2009-10-07 8:43 ` Eero Nurkkala
2009-10-07 8:52 ` Steven Noonan
2009-10-07 9:31 ` Eero Nurkkala
2009-10-07 10:42 ` Thomas Gleixner
2009-10-07 11:03 ` Steven Noonan
2009-10-07 11:15 ` Thomas Gleixner
2009-10-07 11:06 ` [tip:timers/urgent] NOHZ: update idle state also when NOHZ is inactive tip-bot for Eero Nurkkala
2009-10-07 13:35 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACC992F.3060001@redhat.com \
--to=riel@redhat.com \
--cc=ext-eero.nurkkala@nokia.com \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=steven@uplinklabs.net \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome