mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Ungerer <gerg@snapgear.com>
To: Tim Abbott <tabbott@ksplice.com>
Cc: Greg Ungerer <gerg@uclinux.org>,
	linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 2/2] m68knommu: Clean up linker script using new linker script macros.
Date: Tue, 13 Oct 2009 09:46:32 +1000	[thread overview]
Message-ID: <4AD3BFD8.90408@snapgear.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0910010905340.5982@dr-wily.mit.edu>

Hi Tim,

Tim Abbott wrote:
> On Thu, 1 Oct 2009, Greg Ungerer wrote:
>> Tim Abbott wrote:
>>> Signed-off-by: Tim Abbott <tabbott@ksplice.com>
>>> Cc: Greg Ungerer <gerg@uclinux.org>
>> This results in kernels that don't boot for me. I haven't done
>> any more debugging than to just try booting at this time.
> [...]
>> Does that look like what you would have expected?
> 
> Basically.  I'm a bit surprised that the .init_begin section doesn't show 
> up, but I'm pretty sure that this is because .init_begin would have had 
> size zero as the previous section's end was already page-aligned.
> 
>> I suspect the problem may lie in the binary conversion of this
>> elf file to a raw binary for booting. This uses objcopy with
>> "-O binary". The resulting binary files are different in size
>> with and without the patch by about 2582 bytes. Suspicious
>> me thinks.
> 
> I don't any good ideas for what in patch is likely to be responsible.  
> Would it be helpful to debug if I split this into ~5 very small patches so 
> that we can find out what part of the patch is responsible?

Yes, that will make it quick and easy for me.

Thanks
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com

  reply	other threads:[~2009-10-12 23:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 16:56 [PATCH v2 0/2] Linker script cleanup patches for m68knommu Tim Abbott
2009-09-22 16:56 ` [PATCH v2 1/2] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-09-22 16:56 ` [PATCH v2 2/2] m68knommu: Clean up linker script using new linker script macros Tim Abbott
2009-10-01  5:56   ` Greg Ungerer
2009-10-12 14:47     ` Tim Abbott
2009-10-12 23:46       ` Greg Ungerer [this message]
2009-10-13  1:30         ` [PATCH v3 0/7] " Tim Abbott
2009-10-13  1:30           ` [PATCH v3 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script Tim Abbott
2009-10-13  1:30             ` [PATCH v3 2/7] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-10-13  1:30               ` [PATCH v3 3/7] m68knommu: Use INIT_TASK_DATA and CACHELINE_ALIGNED_DATA Tim Abbott
2009-10-13  1:30                 ` [PATCH v3 4/7] m68knommu: Use more macros inside the .init section Tim Abbott
2009-10-13  1:30                   ` [PATCH v3 5/7] m68knommu: Move __init_begin out of " Tim Abbott
2009-10-13  1:30                     ` [PATCH v3 6/7] m68knommu: Move __init_end " Tim Abbott
2009-10-13  1:30                       ` [PATCH v3 7/7] m68knommu: Split the .init section into INIT_TEXT_SECTION and INIT_DATA_SECTION Tim Abbott
2009-10-14  4:41                       ` [PATCH v3 6/7] m68knommu: Move __init_end out of the .init section Greg Ungerer
2009-10-14 15:16                         ` Sam Ravnborg
2009-10-18 17:22                           ` Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 1/7] m68knommu: Don't hardcode the value of PAGE_SIZE in the linker script Tim Abbott
2009-10-30  0:57                               ` Greg Ungerer
2009-10-30  1:22                                 ` Tim Abbott
2009-10-30  5:02                                   ` Greg Ungerer
2009-10-18 17:23                             ` [PATCH v4 2/7] m68knommu: Make THREAD_SIZE available to assembly files Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 3/7] m68knommu: Use INIT_TASK_DATA and CACHELINE_ALIGNED_DATA Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 4/7] m68knommu: Use more macros inside the .init section Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 5/7] m68knommu: Move __init_begin out of " Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 6/7] m68knommu: Move __init_end " Tim Abbott
2009-10-18 17:23                             ` [PATCH v4 7/7] m68knommu: Split the .init section into INIT_TEXT_SECTION and INIT_DATA_SECTION Tim Abbott
2009-10-30  1:13                               ` Greg Ungerer
2009-10-30  1:30                                 ` Tim Abbott
2009-10-30  5:10                                   ` Greg Ungerer
2009-10-30 11:35                                   ` Sam Ravnborg
2009-10-30 18:10                                     ` Tim Abbott
2009-10-30  0:44                           ` [PATCH v3 6/7] m68knommu: Move __init_end out of the .init section Greg Ungerer
2009-10-13  5:55                   ` [PATCH v3 4/7] m68knommu: Use more macros inside " Greg Ungerer
2009-10-13 15:39                     ` Tim Abbott
2009-10-14  4:22                       ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD3BFD8.90408@snapgear.com \
    --to=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tabbott@ksplice.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome