mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <stable@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Withdraw: [PATCH] x86-64: fix another kernel data leak to 32-bit processes
Date: Tue, 20 Oct 2009 07:13:24 +0100	[thread overview]
Message-ID: <4ADD7124020000780001AD37@vpn.id2.novell.com> (raw)

>Unfortunately I didn't realize that the other instances of branches to
>int_ret_from_sys_call also need fixing when preparing the previous
>similar patch. The issue fixed here was in fact introduced by an
>earlier patch of mine (295286a89107c353b9677bc604361c537fd6a1c0, i.e.
>in 2.6.28, but through stable now also present in 2.6.27), making
>kernel stack contents potentially visible through R8...R11 when an
>this or earlier syscall got interrupted prior to the handler being able
>to decrement the stack pointer (such that the space normally used by
>those registers within pt_regs would get overwritten by the interrupt
>handler stub).

That analysis wasn't right after all - there's a CLEAR_RREGS in each of
the modified paths already, so the change is unnecessary (and adding
redundant code). Please don't apply it.

>While touching the code, I also swapped the branch pairs so that the
>static branch prediction logic would consider the syscall-number-in-
>range case the taken path.

If this would seem a worthwhile change, I can re-send it as a separate,
lower priority patch...

Jan


             reply	other threads:[~2009-10-20  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20  6:13 Jan Beulich [this message]
2009-10-20  6:14 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADD7124020000780001AD37@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®