From: "Gregory Haskins" <ghaskins@novell.com>
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>, <linux-kernel@vger.kernel.org>
Subject: Re: Zillions of warnings in -next
Date: Tue, 27 Oct 2009 14:53:33 -0600 [thread overview]
Message-ID: <4AE7258D0200005A000576F6@sinclair.provo.novell.com> (raw)
In-Reply-To: <20091027152530.75ca60e4@lxorguk.ukuu.org.uk>
>>> On 10/27/2009 at 11:25 AM, in message
<20091027152530.75ca60e4@lxorguk.ukuu.org.uk>, Alan Cox
<alan@lxorguk.ukuu.org.uk> wrote:
> I was thinking "what a lot of new warnings". Then I dug a little deeper
> and it seems that someone never bothered to try and build
> drivers/net/vbus-enet.c on a 32bit system.
>
> So would you mind fixing the 27 new warnings introduced ?
>
> Alan
I just did a 32-bit build and indeed reproduced the warnings. However, the warnings
appear to be dubious as the code is properly (afaict) annotated with explicit casts, and
I believe they are doing what I intended.
Basically I have structures that are always 64 bit (so we can have a mixed-mode 32-bit
guest talk to a 64-bit hypervisor, for instance). Therefore I am casting between native
and u64, but the compiler doesn't like this. Does anyone have any suggestions on ways
to fix this so the compiler is happy?
For instance:
struct foo {
u64 bar;
}
xmit_foo(void *ptr)
{
struct foo f;
f->bar = (u64)ptr; /* generates warning */
}
Kind Regards,
-Greg
next prev parent reply other threads:[~2009-10-27 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 15:25 Alan Cox
2009-10-27 15:57 ` Gregory Haskins
2009-10-27 20:53 ` Gregory Haskins [this message]
2009-10-27 22:21 ` Alan Cox
2009-10-27 22:36 ` [patch] " Randy Dunlap
2009-10-27 23:25 ` Joe Perches
2009-10-28 0:08 ` Stefan Richter
2009-10-28 13:35 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE7258D0200005A000576F6@sinclair.provo.novell.com \
--to=ghaskins@novell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®