From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932628AbdJaSgM (ORCPT ); Tue, 31 Oct 2017 14:36:12 -0400 Received: from mail-by2nam03on0084.outbound.protection.outlook.com ([104.47.42.84]:38542 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932423AbdJaSgJ (ORCPT ); Tue, 31 Oct 2017 14:36:09 -0400 From: "Madhani, Himanshu" To: Kees Cook CC: Bart Van Assche , "martin.petersen@oracle.com" , "jejb@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Dept-Eng QLA2xxx Upstream Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTTXkYGo0ktCcFY0ucpeQkciWZRaL+JN91gAAlXQCAAAJvgIAAASsAgAADVgCAAAIagA== Date: Tue, 31 Oct 2017 18:36:07 +0000 Message-ID: <4AF4B68F-9343-437E-ADA7-1675E32998B9@cavium.com> References: <20171025100737.GA145097@beast> <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com> <1509473546.12927.5.camel@wdc.com> <3CE2B08B-07F4-411D-B87A-18F586F5534C@cavium.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR07MB3456;6:/Bc9UYU0w1f5lv3IE73ETxCXTPzZMKIoHsLcFpC22wuCj6zwV0NdKT3PXiBfTod3QksZI5gvkbRuDt2Nqcv+JiL54y6j6Ze6pY4nRAd3sofaHlrY+EH/nN0+25sTHfXePz4LrWxo9WpofORV/kGAkP4TegcmWYRrdvsY19uQXEgrwDbyxDfMlXXqQc4uZmkKzUlKXgkiMe9/BYNyfT9aNa8e/UGNxHOYXfcVAu7knXXN13Hz5TJom4/lkuvSZOC7PkYtw57+BaudRtAFTBJu2+IFsI6fv4Ven0ceZ3Uw2tvR4MXWjw9U4741fOOdw/jYTriyLM83LJKbXMA7OrF8IN/8+ReYP3yrXzkLjNh5ag4=;5:uJzbOAH4mDpF1mHgM6/9XbupbuzNK5uTJHxifnP4VWCzc496AUf159839JCB4ql5sTQMzowudvJOktfSSSbizbkNzaFClG01+qxfOFuY5NQ1Hu4L7ahjAFUY2cjqu8pioZUWLOSoC+zMlyY9exAJsdlmPRB3hU1wyETRdOQNh+k=;24:3lWnCaCniCYci5LAT3jHIvZFCwAA5K1QhpEsMLRA2qQsUnKToOxY4ccEZUZs1L/540iDn7e279QVCmKpWVBELYEmKh5dTLs2/U+ZqwXuvAA=;7:Ng6HhsyztyG5lHRJQb5+jN6LX9nmrmeGWddCci9wyEWfPLnfL62eteWVdYKaPoQ292dAOKSeaaIxoD0xU+6F0VnGE+NwUDPTfCOD/niS7EeC3/M/ipyVWZHxB0/EUYBEOnzDc47XHkCqlH8Evy9VZL8z2JkZNCQjPuaGyZEO6Vp4ccN5nHHOjL10g8Q+4b+XRx2Q9Ec/CITCiVsXGtqTgkk8+3xY2q+bhTq6kXtyt6DgZcPVW+eogroq19qwnD9N x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: d04409b3-61c6-49a5-2a0a-08d5208e3fec x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603199);SRVR:MWHPR07MB3456; x-ms-traffictypediagnostic: MWHPR07MB3456: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(3231020)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3456;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3456; x-forefront-prvs: 04772EA191 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(24454002)(25786009)(68736007)(2900100001)(6916009)(81156014)(3846002)(97736004)(3280700002)(2950100002)(36756003)(8936002)(3660700001)(8676002)(93886005)(81166006)(6116002)(102836003)(54356999)(50986999)(7736002)(305945005)(106356001)(105586002)(66066001)(189998001)(76176999)(53546010)(5660300001)(2906002)(478600001)(4326008)(82746002)(54906003)(6506006)(86362001)(229853002)(33656002)(77096006)(6486002)(6436002)(83716003)(101416001)(72206003)(6246003)(14454004)(53936002)(316002)(107886003)(99286003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3456;H:MWHPR07MB3455.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <434A67F52B6693409FCA4E3A30255C59@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: d04409b3-61c6-49a5-2a0a-08d5208e3fec X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2017 18:36:07.0961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3456 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v9VIaGEj023559 Hi Kees, > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: > > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree patch looks okay, but with the patch built into driver I see system going into infinite loop of trying to bring link up and lock up after few minutes, Only way to recover is hard reboot. I reverted this patch after system boot up and rebuild qla2xxx and able to load driver. Thanks, - Himanshu