From: Jeff Mahoney <jeffm@jeffreymahoney.com>
To: James Bottomley <JBottomley@Novell.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] enclosure: fix oops while iterating enclosure_status array
Date: Thu, 19 Nov 2009 19:23:31 -0500 [thread overview]
Message-ID: <4B05E183.4010301@jeffreymahoney.com> (raw)
enclosure_status is expected to be a NULL terminated array of strings
but isn't actually NULL terminated. When writing an invalid value to
/sys/class/enclosure/.../.../status, it goes off the end of the array
and Oopses.
This patch uses the array size instead.
Reported-by: Artur Wojcik <artur.wojcik@intel.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
drivers/misc/enclosure.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- a/drivers/misc/enclosure.c
+++ b/drivers/misc/enclosure.c
@@ -412,8 +412,9 @@ static ssize_t set_component_status(stru
struct enclosure_component *ecomp = to_enclosure_component(cdev);
int i;
- for (i = 0; enclosure_status[i]; i++) {
- if (strncmp(buf, enclosure_status[i],
+ for (i = 0; i < ARRAY_SIZE(enclosure_status); i++) {
+ if (enclosure_status[i] &&
+ strncmp(buf, enclosure_status[i],
strlen(enclosure_status[i])) == 0 &&
(buf[strlen(enclosure_status[i])] == '\n' ||
buf[strlen(enclosure_status[i])] == '\0'))
--
Jeff Mahoney
next reply other threads:[~2009-11-20 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 0:23 Jeff Mahoney [this message]
2009-11-20 3:33 ` James Bottomley
2009-11-20 21:43 ` James Bottomley
2009-11-26 15:50 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B05E183.4010301@jeffreymahoney.com \
--to=jeffm@jeffreymahoney.com \
--cc=JBottomley@Novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®