From: "Jan Beulich" <JBeulich@novell.com>
To: <Douglas_Warzecha@Dell.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] use proper address translation functions in DCDBAS
Date: Fri, 20 Nov 2009 13:46:00 +0000 [thread overview]
Message-ID: <4B06ABA802000078000211D2@vpn.id2.novell.com> (raw)
In one case, the properly translated address is already available, in
the other virt_to_bus() ought to be used (in particular for Xen
compatibility).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
drivers/firmware/dcdbas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.32-rc8/drivers/firmware/dcdbas.c 2009-06-10 05:05:27.000000000 +0200
+++ 2.6.32-rc8-dcdbas/drivers/firmware/dcdbas.c 2009-10-26 16:34:02.000000000 +0100
@@ -106,7 +106,7 @@ static int smi_data_buf_realloc(unsigned
/* set up new buffer for use */
smi_data_buf = buf;
smi_data_buf_handle = handle;
- smi_data_buf_phys_addr = (u32) virt_to_phys(buf);
+ smi_data_buf_phys_addr = (u32) handle;
smi_data_buf_size = size;
dev_dbg(&dcdbas_pdev->dev, "%s: phys: %x size: %lu\n",
@@ -319,7 +319,7 @@ static ssize_t smi_request_store(struct
break;
case 1:
/* Calling Interface SMI */
- smi_cmd->ebx = (u32) virt_to_phys(smi_cmd->command_buffer);
+ smi_cmd->ebx = (u32) virt_to_bus(smi_cmd->command_buffer);
ret = dcdbas_smi_request(smi_cmd);
if (!ret)
ret = count;
next reply other threads:[~2009-11-20 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 13:46 Jan Beulich [this message]
2009-11-20 14:07 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B06ABA802000078000211D2@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=Douglas_Warzecha@Dell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®