From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5785836E48F
	for <linux-kernel@vger.kernel.org>; Fri, 27 Feb 2026 10:21:57 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1772187718; cv=none; b=ZDffKTbNpIwu4vssRZ2G8EwerPfcue4CcuYw1IVDQZO3h+YMZN1L01immgnh2FKWFiIjQb2hLu1l6zb90rzGhcOvsh3E7NMIRj7GHVyqHiJLBju+HSXD2h6HI5HiGH+cILqixAsmzYLRMy0V+eluS7ipuK94BPbYku/9vJAAOP8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1772187718; c=relaxed/simple;
	bh=VBiYdkQoEqAHAdWh3vj0qeS1ckZVVsowH7HLju9ynZ8=;
	h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:
	 Message-Id:References:To; b=hDXejbIZnL+i2QlEOx6wDHnXrH9Niaw03IV3iBnfkgPmOzsCxbB95RJ7skmOQ9YoOaViZ60eCKoSqSRlere57pelI+8zZGbxkU0Prpyv9QFCQWj09nCvMugzxBOoHcWWX2FZSD3he/696RzNP/saHRN0XzqqzD0RnlzOB/7cJgQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=em5jrlx0; arc=none smtp.client-ip=95.215.58.176
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="em5jrlx0"
Content-Type: text/plain;
	charset=us-ascii
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1;
	t=1772187705;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=mXfrCI3mgkpsLfqiAi5yqQBNesc4wEz0O2OqhGqmiwc=;
	b=em5jrlx0jNNNqBWv9XVE6blN1Q+yLqGSDL5BcZ6JPKMdVF5UXJpLcPIsjcfw/451If4qIC
	m2yHjlBqJ1whtCAx03klzEA+ioKoyCiS+ltEV+D2QReL/MqXS7FOIQUndDD3JtO9hNHfWk
	4uUsrBBsaAdiTPcUdbWCa5qqprNa7Ms=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Subject: Re: [PATCH] tty: vt/keyboard: Hoist and reuse variable in
 vt_do_kdgkb_ioctl
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Thorsten Blum <thorsten.blum@linux.dev>
In-Reply-To: <78bf91c6-8dd7-4c69-bd9f-61551990f02d@kernel.org>
Date: Fri, 27 Feb 2026 11:21:11 +0100
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Alexey Gladkov <legion@kernel.org>,
 Thomas Gleixner <tglx@kernel.org>,
 Nathan Chancellor <nathan@kernel.org>,
 Myrrh Periwinkle <myrrhperiwinkle@qtmlabs.xyz>,
 Kees Cook <kees@kernel.org>,
 linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <4B0BE9EF-7A00-4DE0-B627-32B902E87D06@linux.dev>
References: <20260226123419.737669-1-thorsten.blum@linux.dev>
 <78bf91c6-8dd7-4c69-bd9f-61551990f02d@kernel.org>
To: Jiri Slaby <jirislaby@kernel.org>
X-Migadu-Flow: FLOW_OUT

On 27. Feb 2026, at 08:22, Jiri Slaby wrote:
> On 26. 02. 26, 13:34, Thorsten Blum wrote:
>> Hoist 'len' and use it in both cases.
>> The last 'kbs' assignment is useless and a leftover from commit
>> bfb24564b5fd ("tty: vt/keyboard: use __free()"). Remove it.
> 
> No, kbs is set to NULL by vt_kdskbsent() when it should NOT be freed.

Ugh thanks, I'll drop this part then.