mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Patrick Mullaney" <pmullaney@novell.com>
To: <arnd@arndb.de>
Cc: <bridge@lists.linux-foundation.org>,
	<alacrityvm-devel@lists.sourceforge.net>, <kaber@trash.net>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management
Date: Fri, 27 Nov 2009 10:06:37 -0700	[thread overview]
Message-ID: <4B0FA4AD020000C70007B9AE@soto.provo.novell.com> (raw)

Thanks. I'll post an updated patch.

On Fri, 2009-11-27 at 14:09 +0100, Arnd Bergmann wrote:
> On Friday 13 November 2009, Patrick Mullaney wrote:
> > @@ -551,7 +532,7 @@ static int macvlan_newlink(struct net_device *dev,
> >                 return err;
> >  
> >         list_add_tail(&vlan->list, &port->vlans);
> > -       macvlan_transfer_operstate(dev);
> > +       netif_stacked_transfer_operstate(dev, lowerdev);
> >         return 0;
> >  }
> >  
> > @@ -591,7 +572,8 @@ static int macvlan_device_event(struct notifier_block *unused,
> >         switch (event) {
> >         case NETDEV_CHANGE:
> >                 list_for_each_entry(vlan, &port->vlans, list)
> > -                       macvlan_transfer_operstate(vlan->dev);
> > +                       netif_stacked_transfer_operstate(vlan->dev,
> > +                                                        vlan->lowerdev);
> >                 break;
> >         case NETDEV_FEAT_CHANGE:
> >                 list_for_each_entry(vlan, &port->vlans, list) {
> 
> These have the arguments reversed, lowerdev should come first.
> 
> 	Arnd <><


             reply	other threads:[~2009-11-27 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 17:06 Patrick Mullaney [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-11-13 19:55 [PATCH 0/3] macvlan: support for guest vm direct rx/tx Patrick Mullaney
2009-11-13 19:55 ` [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management Patrick Mullaney
2009-11-27 13:09   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0FA4AD020000C70007B9AE@soto.provo.novell.com \
    --to=pmullaney@novell.com \
    --cc=alacrityvm-devel@lists.sourceforge.net \
    --cc=arnd@arndb.de \
    --cc=bridge@lists.linux-foundation.org \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®