From: "Jan Beulich" <JBeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86/alternatives: check replacementlen <= instrlen at build time
Date: Fri, 27 Nov 2009 15:04:58 +0000 [thread overview]
Message-ID: <4B0FF8AA0200007800022703@vpn.id2.novell.com> (raw)
Having run into the run-(boot-)time check a couple of times lately, I
finally took time to find a build-time check so that one doesn't need
to analyze the register/stack dump and resolve this (through manual
lookup in vmlinux) to the offending construct. The assembler will emit
a message like "Error: value of <num> too large for field of 1 bytes
at <offset>", which while not pointing out the source location still
makes analysis quite a bit easier.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/include/asm/alternative.h | 1 +
1 files changed, 1 insertion(+)
--- linux-2.6.32-rc8/arch/x86/include/asm/alternative.h
+++ 2.6.32-rc8-x86-alternative/arch/x86/include/asm/alternative.h
@@ -84,6 +84,7 @@ static inline void alternatives_smp_swit
" .byte " __stringify(feature) "\n" /* feature bit */ \
" .byte 662b-661b\n" /* sourcelen */ \
" .byte 664f-663f\n" /* replacementlen */ \
+ " .byte 0xff + (664f-663f) - (662b-661b)\n" /* rlen <= slen */ \
".previous\n" \
".section .altinstr_replacement, \"ax\"\n" \
"663:\n\t" newinstr "\n664:\n" /* replacement */ \
next reply other threads:[~2009-11-27 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 15:04 Jan Beulich [this message]
2009-12-02 10:45 ` [tip:x86/asm] x86/alternatives: Check " tip-bot for Jan Beulich
2009-11-27 15:29 [PATCH] x86/alternatives: check " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0FF8AA0200007800022703@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®