From: "Jan Beulich" <JBeulich@novell.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>, <tglx@linutronix.de>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Nick Piggin" <npiggin@suse.de>, <linux-kernel@vger.kernel.org>,
<hpa@zytor.com>
Subject: Re: [PATCH] x86: slightly shorten __ticket_spin_trylock() (v2)
Date: Thu, 03 Dec 2009 11:13:21 +0000 [thread overview]
Message-ID: <4B17AB6102000078000235B0@vpn.id2.novell.com> (raw)
In-Reply-To: <20091203104906.GC7628@elte.hu>
>>> Ingo Molnar <mingo@elte.hu> 03.12.09 11:49 >>>
>Looks much cleaner - and should give us pretty much the same savings as
>the previous patch, right? (if not, do you have a size comparison?)
With upstream code there doesn't appear to be a difference in the
generated code. I noted, however, that with the spinlock contention
patch I have pending as a potential replacement for pv-ops spin locks
(which adds a conditional in the trylock functions) the compiler I use
no longer eliminates one of the two tests of the outcome of the
locking attempt.
Jan
next prev parent reply other threads:[~2009-12-03 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 10:01 Jan Beulich
2009-12-03 10:49 ` Ingo Molnar
2009-12-03 11:13 ` Jan Beulich [this message]
2009-12-03 21:10 ` Linus Torvalds
2009-12-11 15:32 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17AB6102000078000235B0@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®