Re: [PATCH 1/2] EDAC: add __init to i7core_xeon_pci_fixup

[Jiri Slaby <jslaby@suse.cz>]

On 12/05/2009 12:54 AM, Jesse Barnes wrote:
> On Mon, 30 Nov 2009 21:19:41 +0100
> Jiri Slaby <jslaby@suse.cz> wrote:
> 
>> It's called only from an __init function and is the only user
>> of pcibios_scan_specific_bus which will be marked as __devinit in
>> the next patch.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>> ---
>>  drivers/edac/i7core_edac.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>> index 4de5a18..c7fc0d5 100644
>> --- a/drivers/edac/i7core_edac.c
>> +++ b/drivers/edac/i7core_edac.c
>> @@ -1141,7 +1141,7 @@ static void i7core_put_all_devices(void)
>>  		i7core_put_devices(i7core_dev);
>>  }
>>  
>> -static void i7core_xeon_pci_fixup(int dev_id)
>> +static void __init i7core_xeon_pci_fixup(int dev_id)
>>  {
>>  	struct pci_dev *pdev = NULL;
>>  	int i;
> 
> I don't know who handles EDAC patches, but I'm pretty sure it's not
> me. :) 

Yeah, sorry, it was just I wanted you to know about the function user.
The EDAC masters were in CC, I hope.

> It doesn't apply to my tree anyway, so it probably needs a
> refresh.

I'll resend both patches after rebasing them.

thanks,
-- 
js
suse labs