mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Etienne Le Sueur <elesueur@cse.unsw.edu.au>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/char/nvram.c: Undo removal of duplicated include
Date: Thu, 10 Dec 2009 13:04:53 +1100	[thread overview]
Message-ID: <4B205745.7060704@cse.unsw.edu.au> (raw)

elesueur@bitburger:/usr/src/linux-2.6-git$ make
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   SYMLINK include/asm -> include/asm-x86
   CALL    scripts/checksyscalls.sh
   CHK     include/linux/compile.h
   CC      drivers/char/consolemap_deftbl.o
   CC      drivers/char/defkeymap.o
   LD      drivers/char/built-in.o
   CC [M]  drivers/char/nvram.o
drivers/char/nvram.c: In function 'nvram_open':
drivers/char/nvram.c:332: error: implicit declaration of function 
'lock_kernel'
drivers/char/nvram.c:339: error: implicit declaration of function 
'unlock_kernel'
make[2]: *** [drivers/char/nvram.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

a check shows commit id: 4d8f54d9e4323baae8c8ca753db91563f4b34ddb 
removed a 'duplicated include' which I believe is erroneous.




diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
index 2100a8f..3cfa0f6 100644
--- a/drivers/char/nvram.c
+++ b/drivers/char/nvram.c
@@ -38,6 +38,7 @@
  #define NVRAM_VERSION  "1.3"

  #include <linux/module.h>
+#include <linux/smp_lock.h>
  #include <linux/nvram.h>

  #define PC             1


Regards,
Etienne Le Sueur
www.ertos.nicta.com.au

             reply	other threads:[~2009-12-10  2:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10  2:04 Etienne Le Sueur [this message]
2009-12-10  8:45 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B205745.7060704@cse.unsw.edu.au \
    --to=elesueur@cse.unsw.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®