mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pieter Palmers <pieterp@joow.be>
Cc: linux-kernel@vger.kernel.org,
	Clemens Ladisch <cladisch@fastmail.net>,
	linux1394-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/5] firewire: fix use of multiple AV/C devices, allow multiple FCP listeners
Date: Sat, 26 Dec 2009 15:33:16 +0100	[thread overview]
Message-ID: <4B361EAC.2090605@s5r6.in-berlin.de> (raw)
In-Reply-To: <4B361A23.8090009@s5r6.in-berlin.de>

Stefan Richter wrote:
> BTW, what about AV/C RESERVE?  According to the spec, it means that a
> controller gets exclusive FCP access to a target.  At this point, a
> node-wide FCP serializer will have to decide on a policy:

(because the spec does not have a concept of reservation IDs.  It
stupidly takes node IDs for what should be reservation IDs even though
it distinguishes between the concepts of 'controller' and 'node'.)

> The simpler policy would be to remain oblivious of RESERVE.  The more
> difficult to implement policy would be to keep track of reservations
> and only allow a single controller process (or user, or...) to perform
> subsequent transactions for the duration of a reservation.

Err, no, forget that.  A reservation prevents only control commands, but
AFAIU not even all control commands because subunit specifications may
enumerate control commands that are still allowed during a reservation.
So the serializer would have to have knowledge of subunit specs.  That
would quickly get out of hand.

> (I for one would keep it simple.)
-- 
Stefan Richter
-=====-==--= ==-- ==-=-
http://arcgraph.de/sr/

  reply	other threads:[~2009-12-26 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-26  0:32 [PATCH 0/5] firewire: fixes, status update Stefan Richter
2009-12-26  0:33 ` [PATCH 1/5] firewire: fix use of multiple AV/C devices, allow multiple FCP listeners Stefan Richter
2009-12-26  8:35   ` Pieter Palmers
2009-12-26 12:01     ` Stefan Richter
2009-12-26 13:23       ` Pieter Palmers
2009-12-26 14:13         ` Stefan Richter
2009-12-26 14:33           ` Stefan Richter [this message]
2010-01-23 14:51   ` Stefan Richter
2010-01-24 15:45     ` [PATCH] firewire: core: fix use-after-free regression in FCP handler Stefan Richter
2009-12-26  0:34 ` [PATCH 2/5] firewire: cdev: fix another memory leak in an error path Stefan Richter
2009-12-26  0:35 ` [PATCH 3/5] firewire: ohci: always use packet-per-buffer mode for isochronous reception Stefan Richter
2009-12-26  0:36 ` [PATCH 4/5] firewire, ieee1394: update MAINTAINERS entries Stefan Richter
2009-12-26 15:57   ` Dan Dennedy
2009-12-26  0:36 ` [PATCH 5/5] firewire, ieee1394: update Kconfig help Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B361EAC.2090605@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=cladisch@fastmail.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=pieterp@joow.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®