From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755893Ab0AFTOb (ORCPT ); Wed, 6 Jan 2010 14:14:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754858Ab0AFTO2 (ORCPT ); Wed, 6 Jan 2010 14:14:28 -0500 Received: from mail-fx0-f225.google.com ([209.85.220.225]:62436 "EHLO mail-fx0-f225.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188Ab0AFTO1 (ORCPT ); Wed, 6 Jan 2010 14:14:27 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=ZSVUXqlRKg5/eS3NY/oUihOz135K5Uq8HuBNX90XFV20rVa4Yypf3IoOEBPvKc8s7U PHSEjQ+F3kNfHKMGpsJqT6yr/4yqfZrCPegKEBHoWRs+9KHEBt1uM53xhDkBK90xVv18 v3KxEJHFRDLlTZ5BHo/C3MQm/Rcyb7r8BAxRo= Message-ID: <4B44E10D.7090802@gmail.com> Date: Wed, 06 Jan 2010 20:14:21 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-16.1 Thunderbird/3.0 MIME-Version: 1.0 To: Gertjan van Wingerde CC: linville@tuxdriver.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] NET: wireless, fix memory leak References: <1262795743-15009-1-git-send-email-jslaby@suse.cz> <1262795743-15009-2-git-send-email-jslaby@suse.cz> <4B44DF84.80206@gmail.com> In-Reply-To: <4B44DF84.80206@gmail.com> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2010 08:07 PM, Gertjan van Wingerde wrote: > On 01/06/10 17:35, Jiri Slaby wrote: >> @@ -717,6 +717,9 @@ int cfg80211_wext_siwscan(struct net_device *dev, >> out: >> cfg80211_unlock_rdev(rdev); >> return err; >> +out_free: >> + kfree(creq); >> + goto out; >> } >> EXPORT_SYMBOL_GPL(cfg80211_wext_siwscan); >> > > This last part looks a bit strange. Why don't you put out_free label before out label, Because `out' is a part of non-error flow, where the creq should not be freed. thanks, -- js