From: James Smart <james.smart@emulex.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: Thomas Backlund <tmb@mandriva.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: latest git pull changed drivers/scsi/lpfc/lpfc_hw4.h to executable
Date: Thu, 7 Jan 2010 09:59:31 -0500 [thread overview]
Message-ID: <4B45F6D3.40903@emulex.com> (raw)
In-Reply-To: <1262875521.3025.5.camel@mulgrave.site>
Thank You James. Sorry for the disruption. This is what I get for moving to a
git-derived patch, instead of my own diff scripts which ignore things like
this. Don't know what changed it in the first place.
-- james s
James Bottomley wrote:
> On Thu, 2010-01-07 at 12:16 +0200, Thomas Backlund wrote:
>> At latest pull, lpfs_hw4.h got set to executable...
>>
>> git show def9c7a994f194377a23e687e6fd39b46c3ce631 --summary
>>
>> states:
>>
>> commit def9c7a994f194377a23e687e6fd39b46c3ce631
>> Author: James Smart <james.smart@emulex.com>
>> Date: Mon Dec 21 17:02:28 2009 -0500
>>
>> [SCSI] lpfc 8.3.7: Fix hardware/SLI relates issues
>>
>> Fix hardware/SLI relates issues:
>> - Fix CNA uses more than one EQ when in INTx interrupt mode.
>> - Fix driver tries to process failed read FCF record mailbox request.
>> - Fix allocating single receive buffer breaks FCoE receive queue.
>> - Support new read FCF record mailbox error case.
>>
>> Signed-off-by: James Smart <james.smart@emulex.com>
>> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
>>
>> mode change 100644 => 100755 drivers/scsi/lpfc/lpfc_hw4.h
>>
>>
>> While looking at the same tree, I also noticed that:
>> drivers/scsi/lpfc/lpfc_hbadisc.c is also executable.
>>
>> I guess they should be fixed.
>
> I'll remove the x flag for both. I suppose a commit check that warns on
> executables might be in order, since adding them to the tree is a rare
> exception rather than a usual occurrence.
>
> James
>
>
prev parent reply other threads:[~2010-01-07 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 10:16 Thomas Backlund
2010-01-07 14:45 ` James Bottomley
2010-01-07 14:59 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B45F6D3.40903@emulex.com \
--to=james.smart@emulex.com \
--cc=James.Bottomley@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tmb@mandriva.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome