From: Roel Kluin <roel.kluin@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: HID: is scancode correctly reported after key status change in hidinput_hid_event()?
Date: Sat, 09 Jan 2010 16:05:40 +0100 [thread overview]
Message-ID: <4B489B44.50101@gmail.com> (raw)
vi drivers/hid/hid-input.c +634 and not in hidinput_hid_event()
/* report the usage code as scancode if the key status has changed */
if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
input_event(input, EV_MSC, MSC_SCAN, usage->hid);
Only if value is 1 or 0 the input_event() can occur, but value doesn't
seem to be intended to be used as a boolean. are we really doing the
correct test here?
Roel
next reply other threads:[~2010-01-09 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 15:05 Roel Kluin [this message]
2010-01-09 15:15 ` Jiri Kosina
2010-01-09 18:51 ` roel kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B489B44.50101@gmail.com \
--to=roel.kluin@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®