From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093Ab0AJOfu (ORCPT ); Sun, 10 Jan 2010 09:35:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753987Ab0AJOfi (ORCPT ); Sun, 10 Jan 2010 09:35:38 -0500 Received: from mail02a.mail.t-online.hu ([84.2.40.7]:49381 "EHLO mail02a.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713Ab0AJOfU (ORCPT ); Sun, 10 Jan 2010 09:35:20 -0500 X-Authuid: nmarci Message-ID: <4B49E5A2.1080301@freemail.hu> Date: Sun, 10 Jan 2010 15:35:14 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: linux-usb@vger.kernel.org, LKML , Julia Lawall , cocci@diku.dk Subject: [PATCH 8/9] USB gadget: make Open Firmware device id constant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-DCC-mail.t-online.hu-Metrics: mail02a.mail.t-online.hu 32721; Body=5 Fuz1=5 Fuz2=5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Márton Németh The match_table field of the struct of_device_id is constant in so it is worth to make ace_of_match also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // Signed-off-by: Márton Németh Cc: Julia Lawall Cc: cocci@diku.dk --- diff -u -p a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c --- a/drivers/usb/gadget/fsl_qe_udc.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/usb/gadget/fsl_qe_udc.c 2010-01-08 17:11:53.000000000 +0100 @@ -2749,7 +2749,7 @@ static int __devexit qe_udc_remove(struc } /*-------------------------------------------------------------------------*/ -static struct of_device_id __devinitdata qe_udc_match[] = { +static const struct of_device_id qe_udc_match[] __devinitconst = { { .compatible = "fsl,mpc8323-qe-usb", .data = (void *)PORT_QE,