From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-media@vger.kernel.org
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4l/dvb] firedtv: add forgotten __exit annotation
Date: Sun, 10 Jan 2010 16:12:30 +0100 [thread overview]
Message-ID: <4B49EE5E.9040904@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.c98a9e80d83e315a@s5r6.in-berlin.de>
Stefan Richter wrote on 2009-12-26:
> fdtv_fw_exit() is part of the firedtv driver's .exit.text section.
...
> --- linux-2.6.33-rc2.orig/drivers/media/dvb/firewire/firedtv-fw.c
> +++ linux-2.6.33-rc2/drivers/media/dvb/firewire/firedtv-fw.c
> @@ -332,7 +332,7 @@ int __init fdtv_fw_init(void)
> return driver_register(&fdtv_driver.driver);
> }
>
> -void fdtv_fw_exit(void)
> +void __exit fdtv_fw_exit(void)
> {
> driver_unregister(&fdtv_driver.driver);
> fw_core_remove_address_handler(&fcp_handler);
>
This patch is bogus. fdtv_fw_exit() is also called from firedtv's init.
--
Stefan Richter
-=====-==-=- ---= -=-=-
http://arcgraph.de/sr/
prev parent reply other threads:[~2010-01-10 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 0:45 Stefan Richter
2010-01-10 15:12 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B49EE5E.9040904@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®