From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Németh Márton" <nm127@freemail.hu>
Cc: linux1394-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>, Julia Lawall <julia@diku.dk>,
cocci@diku.dk
Subject: Re: [PATCH] firewire: make PCI device id constant
Date: Sun, 10 Jan 2010 17:08:03 +0100 [thread overview]
Message-ID: <4B49FB63.8050700@s5r6.in-berlin.de> (raw)
In-Reply-To: <4B49C4A2.50804@freemail.hu>
Németh Márton wrote:
> The id_table field of the struct pci_driver is constant in <linux/pci.h>
> so it is worth to make pci_table also constant.
[...]
> --- a/drivers/firewire/ohci.c 2010-01-07 19:08:39.000000000 +0100
> +++ b/drivers/firewire/ohci.c 2010-01-08 09:51:11.000000000 +0100
> @@ -2657,7 +2657,7 @@ static int pci_resume(struct pci_dev *de
> }
> #endif
>
> -static struct pci_device_id pci_table[] = {
> +static const struct pci_device_id pci_table[] = {
> { PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_FIREWIRE_OHCI, ~0) },
> { }
> };
Committed to linux1394-2.6.git with an adequately shortened changelog.
--
Stefan Richter
-=====-==-=- ---= -=-=-
http://arcgraph.de/sr/
prev parent reply other threads:[~2010-01-10 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 12:14 Németh Márton
2010-01-10 16:08 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B49FB63.8050700@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=cocci@diku.dk \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome