From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Julia Lawall <julia@diku.dk>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Dimitri Sivanich <sivanich@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/9] drivers/char: Eliminate useless code
Date: Sun, 17 Jan 2010 12:40:36 +0100 [thread overview]
Message-ID: <4B52F734.6000408@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1001161656560.28745@ask.diku.dk>
Julia Lawall wrote:
> The variable x is initialized twice to the same (side effect-free)
> expression. Drop one initialization.
[...]
> --- a/drivers/char/mmtimer.c
> +++ b/drivers/char/mmtimer.c
> @@ -546,9 +546,9 @@ static void mmtimer_tasklet(unsigned long data)
> {
> int nodeid = data;
> struct mmtimer_node *mn = &timers[nodeid];
> - struct mmtimer *x = rb_entry(mn->next, struct mmtimer, list);
> + struct mmtimer *x;
> struct k_itimer *t;
> unsigned long flags;
The next x = rb_entry(mn->next, struct mmtimer, list); is preceded by a
test whether mn->next is NULL.
Unless that test is redundant too, your patch fixes a potential NULL
pointer dereference, introduced by commit cbacdd95 "SGI Altix mmtimer:
allow larger number of timers per node" in 2.6.26.
--
Stefan Richter
-=====-==-=- ---= =---=
http://arcgraph.de/sr/
prev parent reply other threads:[~2010-01-17 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 15:57 Julia Lawall
2010-01-17 11:40 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B52F734.6000408@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®