From: Nigel Cunningham <ncunningham@crca.org.au>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Greg KH <greg@kroah.com>,
LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [linux-pm] [PATCH 1/2] PM / Runtime: Add sysfs switch for disabling device run-time PM (rev. 2)
Date: Fri, 05 Feb 2010 19:03:20 +1100 [thread overview]
Message-ID: <4B6BD0C8.5020400@crca.org.au> (raw)
In-Reply-To: <20100204224623.GB1436@ucw.cz>
Hi Pavel et al.
Pavel Machek wrote:
> Hi!
>
>> /*
>> + * control - Report/change current runtime PM setting of the device
>> + *
>> + * Runtime power management of a device can be blocked with the help of
>> + * this attribute. All devices have one of the following two values for
>> + * the power/control file:
>> + *
>> + * + "auto\n" to allow the device to be power managed at run time;
>> + * + "on\n" to prevent the device from being power managed at run time;
>
> I find interface with mandatory \n quite 'interesting'.
Agreed.
> Plus english is strange here. All devices have ... "auto" to allow...?
> Strange formulation. List the values first, then add "write ... to allow"?
It seems okay to me because of the preceding sentence ending in a colon.
Regards,
Nigel
next prev parent reply other threads:[~2010-02-05 8:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 0:29 [RFC][PATCH] PM / Runtime: Add sysfs switch for disabling device run-time PM Rafael J. Wysocki
2010-01-18 16:10 ` Alan Stern
2010-01-18 22:25 ` [Update][RFC][PATCH] " Rafael J. Wysocki
2010-01-19 15:40 ` Alan Stern
2010-01-19 20:32 ` Rafael J. Wysocki
2010-01-19 23:27 ` Rafael J. Wysocki
2010-01-20 15:09 ` Alan Stern
2010-01-20 21:09 ` Rafael J. Wysocki
2010-01-20 21:37 ` Alan Stern
2010-01-20 22:17 ` Rafael J. Wysocki
2010-01-20 2:51 ` [RFC][PATCH] " Greg KH
2010-01-20 20:55 ` Rafael J. Wysocki
2010-01-20 22:50 ` Greg KH
2010-01-21 22:57 ` [PATCH 0/2] " Rafael J. Wysocki
2010-01-21 22:59 ` [PATCH 1/2] PM / Runtime: Add sysfs switch for disabling device run-time PM (rev. 2) Rafael J. Wysocki
2010-01-22 3:02 ` Alan Stern
2010-01-22 20:56 ` Rafael J. Wysocki
2010-01-22 22:45 ` Alan Stern
2010-01-22 22:55 ` Rafael J. Wysocki
2010-01-23 3:22 ` Alan Stern
2010-01-23 12:14 ` Rafael J. Wysocki
2010-01-23 15:20 ` Alan Stern
2010-01-23 20:08 ` Rafael J. Wysocki
2010-02-04 22:46 ` Pavel Machek
2010-02-04 23:08 ` Rafael J. Wysocki
2010-02-05 6:27 ` Pavel Machek
2010-02-05 15:19 ` Alan Stern
2010-02-05 8:03 ` Nigel Cunningham [this message]
2010-01-21 23:00 ` [PATCH 2/2] PM: Document device power attributes in sysfs Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6BD0C8.5020400@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome