From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933724Ab0BQAHY (ORCPT ); Tue, 16 Feb 2010 19:07:24 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:18517 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933683Ab0BQAHV (ORCPT ); Tue, 16 Feb 2010 19:07:21 -0500 Message-ID: <4B7B32C4.6070802@oracle.com> Date: Tue, 16 Feb 2010 16:05:24 -0800 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Greg KH CC: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , devel@driverdev.osuosl.org, David Airlie Subject: Re: [PATCH -next] staging/vmwgfx: depends on FB References: <20100216185534.fdc8eed3.sfr@canb.auug.org.au> <4B7B233F.9000507@oracle.com> <20100216230537.GA19450@suse.de> <4B7B270A.2090609@oracle.com> <20100216232216.GA18733@suse.de> In-Reply-To: <20100216232216.GA18733@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4B7B332D.0051:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/10 15:22, Greg KH wrote: > On Tue, Feb 16, 2010 at 03:15:22PM -0800, Randy Dunlap wrote: >> On 02/16/10 15:05, Greg KH wrote: >>> On Tue, Feb 16, 2010 at 02:59:11PM -0800, Randy Dunlap wrote: >>>> From: Randy Dunlap >>>> >>>> vmwfgx uses framebuffer interfaces, so it should depend on FB. >>>> Otherwise it has these build errors (e.g., when CONFIG_FB=m): >>>> >>>> drivers/built-in.o: In function `vmw_fb_close': >>>> (.text+0x97713): undefined reference to `unregister_framebuffer' >>>> drivers/built-in.o: In function `vmw_fb_close': >>>> (.text+0x97754): undefined reference to `framebuffer_release' >>>> drivers/built-in.o: In function `vmw_fb_init': >>>> (.text+0x97e1c): undefined reference to `framebuffer_alloc' >>>> drivers/built-in.o: In function `vmw_fb_init': >>>> (.text+0x9838d): undefined reference to `register_framebuffer' >>>> drivers/built-in.o: In function `vmw_fb_init': >>>> (.text+0x9842a): undefined reference to `framebuffer_release' >>>> >>>> Signed-off-by: Randy Dunlap >>>> --- >>>> drivers/gpu/drm/vmwgfx/Kconfig | 2 +- >>> >>> This is not a drivers/staging/* file, so there's not much I can do with >>> it. It belongs to David Airlie. >> >> OK, I'll resend it to him, thanks. >> >> I think I was confused by drivers/staging/Kconfig: >> >> source "drivers/gpu/drm/vmwgfx/Kconfig" >> >> source "drivers/gpu/drm/nouveau/Kconfig" >> >> >> Why are those lines there?? > > Because those modules are "hidden" behind the CONFIG_STAGING option. oh well, that doesn't clarify anything. :( -- ~Randy