From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Joe Perches <joe@perches.com>
Cc: Greg KH <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>,
devel <devel@driverdev.osuosl.org>,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl
Date: Wed, 10 Mar 2010 19:35:58 +0100 [thread overview]
Message-ID: <4B97E68E.2070205@s5r6.in-berlin.de> (raw)
In-Reply-To: <1268179619.1545.95.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Tue, 2010-03-09 at 15:41 -0800, Greg KH wrote:
>> It's better that you look at the code yourself, and make the change that
>> looks correct, which is not always the same thing that an automated tool
>> would do.
>
> I disagree.
>
> It's better to make changes that _actually are_ correct.
> People also neglect to see and convert a lot of things.
There is no correct and incorrect style.
There is only
- accepted/ not accepted style,
- good/ bad style.
--
Stefan Richter
-=====-==-=- --== -=-=-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-03-10 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 23:32 Joe Perches
2010-03-09 23:41 ` Greg KH
2010-03-10 0:06 ` Joe Perches
2010-03-10 0:16 ` Greg KH
2010-03-10 0:34 ` Joe Perches
2010-03-10 18:35 ` Stefan Richter [this message]
2010-03-10 18:38 ` Joe Perches
2010-03-10 1:22 ` Frans Pop
2010-03-10 3:25 ` [PATCH V2] scripts/cvt_kernel_style.pl: partial "kernel style" pretty-printing Joe Perches
2010-03-24 20:01 ` [PATCH] scripts/cvt_kernel_style.pl: kernel style source code reformatter Joe Perches
2010-03-24 22:31 ` Frans Pop
2010-03-10 18:32 ` Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B97E68E.2070205@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=apw@shadowen.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®