From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Lars Lindley <lindley@coyote.org>
Cc: Pavel Machek <pavel@ucw.cz>,
gregkh@suse.de, penberg@cs.helsinki.fi, diegoliz@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <lindley@coyote.org>
Date: Sat, 13 Mar 2010 11:37:16 +0100 [thread overview]
Message-ID: <4B9B6ADC.6060204@s5r6.in-berlin.de> (raw)
In-Reply-To: <4B9B6409.3070502@coyote.org>
Lars Lindley wrote:
> + } else { /*DSSS*/
> + /*CTS duration
> + *2 SIFS + DATA transmit time + 1 ACK
> + * Rate : ?? Mega bps
> + *ACK frame length = 14 bytes*/
> + if (pT01->T01_plcp_header_length) /*long preamble*/
> + Duration = LONG_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
> else
> - Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
> + Duration = SHORT_PREAMBLE_PLUS_PLCPHEADER_TIME*2;
Multiline comments are formatted as
/*
* 1st line
* last line
*/
in new code.
The whitespace in the if--else clause went worse. Indent by tabs, not
spaces. Furthermore, there should be spaces around * operators.
(BTW, winbond/README alias winbond/TODO doesn't mention it, but another
(trivial) step is going to be to change variable names and function
names from CamelCase to lower_case spelling.)
--
Stefan Richter
-=====-==-=- --== -==-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-03-13 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 21:45 Lars Lindley
2010-03-13 6:31 ` Pavel Machek
2010-03-13 10:08 ` Lars Lindley
2010-03-13 10:12 ` Pavel Machek
2010-03-13 10:37 ` Stefan Richter [this message]
2010-03-13 11:20 ` [patch] staging/winbond: camelCase should be fixed Pavel Machek
2010-03-14 9:46 ` Pekka Enberg
2010-04-27 20:47 ` [PATCH] staging: winbond: Formatting, whitespace etc in mds.c I fixed most of the problems found by checkpatch.pl. Some long lines are left and some KERN_.. Signed-off-by: Lars Lindley <lindley@coyote.org> Greg KH
2010-04-27 20:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9B6ADC.6060204@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=devel@driverdev.osuosl.org \
--cc=diegoliz@gmail.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®