mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@linux-foundation.org,
	sgruszka@redhat.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] Document Linux's circular buffering capabilities
Date: Mon, 15 Mar 2010 14:43:10 +0100	[thread overview]
Message-ID: <4B9E396E.8050606@s5r6.in-berlin.de> (raw)
In-Reply-To: <30121.1268656565@redhat.com>

David Howells wrote:
> How about adding a bit:
> 
>  Note the use of ACCESS_ONCE() in both algorithms to read the opposition index.
>  This prevents the compiler from discarding and reloading its cached value -
> -which some compilers will do across smp_read_barrier_depends().
> +which some compilers will do across smp_read_barrier_depends().  This isn't
> +strictly needed if you can be sure that the opposition index will _only_ be
> +used the once.

Yes, thanks.  (The last "the" is superfluous.)
-- 
Stefan Richter
-=====-==-=- --== -====
http://arcgraph.de/sr/

  reply	other threads:[~2010-03-15 13:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 17:20 David Howells
2010-03-11 18:10 ` Randy Dunlap
2010-03-11 19:20 ` David Howells
2010-03-12 15:39 ` Stefan Richter
2010-03-12 23:41 ` David Howells
2010-03-13  9:26   ` Stefan Richter
2010-03-15 12:36   ` David Howells
2010-03-15 13:43     ` Stefan Richter [this message]
2010-03-19 17:53       ` Mark Rustad
2010-03-15 13:55     ` David Howells
2010-03-15 14:16       ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E396E.8050606@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rdunlap@xenotime.net \
    --cc=sgruszka@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®