From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700Ab0CRIDd (ORCPT ); Thu, 18 Mar 2010 04:03:33 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:53092 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229Ab0CRIDa (ORCPT ); Thu, 18 Mar 2010 04:03:30 -0400 Message-ID: <4BA1DE50.1080908@cs.helsinki.fi> Date: Thu, 18 Mar 2010 10:03:28 +0200 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Lars Lindley CC: gregkh@suse.de, greg@kroah.com, pavel@ucw.cz, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: winbond: mds_f.h whitespace corrections. References: <1268899193-16034-1-git-send-email-lindley@coyote.org> In-Reply-To: <1268899193-16034-1-git-send-email-lindley@coyote.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lars Lindley kirjoitti: > I fixed the whitespaces and the C99 comment. > > Signed-off-by: Lars Lindley > --- > drivers/staging/winbond/mds_f.h | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h > index e09dd4b..0d2bccf 100644 > --- a/drivers/staging/winbond/mds_f.h > +++ b/drivers/staging/winbond/mds_f.h > @@ -4,17 +4,17 @@ > #include "wbhal_s.h" > #include "core.h" > > -unsigned char Mds_initial( struct wbsoft_priv *adapter ); > -void Mds_Destroy( struct wbsoft_priv *adapter ); > -void Mds_Tx( struct wbsoft_priv *adapter ); > -void Mds_SendComplete( struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02 ); > -void Mds_MpduProcess( struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes ); > +unsigned char Mds_initial(struct wbsoft_priv *adapter); > +void Mds_Destroy(struct wbsoft_priv *adapter); > +void Mds_Tx(struct wbsoft_priv *adapter); > +void Mds_SendComplete(struct wbsoft_priv *adapter, PT02_DESCRIPTOR pT02); > +void Mds_MpduProcess(struct wbsoft_priv *adapter, struct wb35_descriptor *pRxDes); > extern void DataDmp(u8 *pdata, u32 len, u32 offset); > > -// For data frame sending 20060802 > -u16 MDS_GetPacketSize( struct wbsoft_priv *adapter ); > -void MDS_GetNextPacket( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes ); > -void MDS_GetNextPacketComplete( struct wbsoft_priv *adapter, struct wb35_descriptor *pDes ); > -void MDS_SendResult( struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK ); > +/* For data frame sending */ > +u16 MDS_GetPacketSize(struct wbsoft_priv *adapter); > +void MDS_GetNextPacket(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes); > +void MDS_GetNextPacketComplete(struct wbsoft_priv *adapter, struct wb35_descriptor *pDes); > +void MDS_SendResult(struct wbsoft_priv *adapter, u8 PacketId, unsigned char SendOK); While you're at it, how about fixing up those CamelCase parameter names as well? Pekka