From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735Ab0CVMjR (ORCPT ); Mon, 22 Mar 2010 08:39:17 -0400 Received: from ppsw-6.csi.cam.ac.uk ([131.111.8.136]:34611 "EHLO ppsw-6.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754631Ab0CVMjP (ORCPT ); Mon, 22 Mar 2010 08:39:15 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Message-ID: <4BA76586.6040200@jic23.retrosnub.co.uk> Date: Mon, 22 Mar 2010 12:41:42 +0000 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20100109 Thunderbird/3.0 MIME-Version: 1.0 To: Wolfram Sang CC: kernel-janitors@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: Re: [PATCH 22/24] staging/iio/light: fix dangling pointers References: <1269094385-16114-1-git-send-email-w.sang@pengutronix.de> <1269094385-16114-23-git-send-email-w.sang@pengutronix.de> In-Reply-To: <1269094385-16114-23-git-send-email-w.sang@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/10 14:13, Wolfram Sang wrote: > Fix I2C-drivers which missed setting clientdata to NULL before freeing the > structure it points to. Also fix drivers which do this _after_ the structure > was freed already. > > Signed-off-by: Wolfram Sang > Cc: Greg Kroah-Hartman Acked-by: Jonathan Cameron Thanks for this one as well! > --- > > Found using coccinelle, then reviewed. Full patchset is available via > kernel-janitors, linux-i2c, and LKML. > --- > drivers/staging/iio/light/tsl2563.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c > index 78b9432..286559d 100644 > --- a/drivers/staging/iio/light/tsl2563.c > +++ b/drivers/staging/iio/light/tsl2563.c > @@ -681,6 +681,7 @@ static int __devinit tsl2563_probe(struct i2c_client *client, > fail2: > iio_device_unregister(chip->indio_dev); > fail1: > + i2c_set_clientdata(client, NULL); > kfree(chip); > return err; > } > @@ -691,6 +692,7 @@ static int tsl2563_remove(struct i2c_client *client) > > iio_device_unregister(chip->indio_dev); > > + i2c_set_clientdata(client, NULL); > kfree(chip); > return 0; > }