mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -v4 2/2] bootmem, x86: Fix 32bit numa system without RAM on Node0
Date: Wed, 31 Mar 2010 20:45:27 -0700	[thread overview]
Message-ID: <4BB416D7.6090203@kernel.org> (raw)
In-Reply-To: <4BB41689.9090502@kernel.org>


When 32bit numa is used, free_all_bootmem() will still only go over with
node id 0.

If node 0 doesn't have RAM installed, We need to go with node1
because early_node_map still use 1 for all ranges, and ram from node1
become low ram.

this one fixes BOOTMEM path by loop bdata_list.

-v3: add more comments, and fix bootmem path too.
-v4: seperate from one big patch

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 mm/bootmem.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Index: linux-2.6/mm/bootmem.c
===================================================================
--- linux-2.6.orig/mm/bootmem.c
+++ linux-2.6/mm/bootmem.c
@@ -312,7 +312,13 @@ unsigned long __init free_all_bootmem(vo
 	 */
 	return free_all_memory_core_early(MAX_NUMNODES);
 #else
-	return free_all_bootmem_core(NODE_DATA(0)->bdata);
+	unsigned long total_pages = 0;
+	bootmem_data_t *bdata;
+
+	list_for_each_entry(bdata, &bdata_list, list)
+		total_pages += free_all_bootmem_core(bdata);
+
+	return total_pages;
 #endif
 }
 

  reply	other threads:[~2010-04-01  3:47 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31  4:49 Config NO_BOOTMEM breaks my amd64 box James Morris
2010-03-31  6:26 ` H. Peter Anvin
2010-03-31  6:47   ` James Morris
2010-03-31 16:25     ` Yinghai Lu
2010-03-31 18:59     ` Ingo Molnar
2010-03-31 20:57       ` Dave Airlie
2010-03-31 21:02         ` Linus Torvalds
2010-03-31 21:40           ` Ingo Molnar
2010-03-31 21:47         ` Ingo Molnar
2010-03-31 21:14       ` Dave Airlie
2010-03-31 22:02         ` Yinghai Lu
2010-03-31 22:28         ` H. Peter Anvin
2010-03-31 22:58       ` James Morris
2010-03-31 23:02         ` Ingo Molnar
2010-03-31 23:35         ` H. Peter Anvin
2010-03-31 23:43           ` James Morris
2010-03-31 23:48             ` H. Peter Anvin
2010-04-01  1:00               ` James Morris
2010-04-01 12:52                 ` Ingo Molnar
2010-04-08  6:32                   ` Ingo Molnar
2010-04-08  7:00                     ` Yinghai
2010-04-08  7:27                       ` Ingo Molnar
2010-04-09  2:43                         ` Dave Airlie
2010-04-08  8:05                     ` James Morris
2010-04-08  8:22                       ` Ingo Molnar
2010-03-31 22:05     ` Yinghai Lu
2010-03-31 22:13       ` Ingo Molnar
2010-03-31 22:16         ` Yinghai Lu
2010-03-31 22:41           ` Ingo Molnar
2010-03-31 22:47             ` Yinghai Lu
2010-03-31 22:56               ` Ingo Molnar
2010-04-01  0:01                 ` Johannes Weiner
2010-03-31 23:34               ` H. Peter Anvin
2010-03-31 23:54                 ` Yinghai Lu
2010-04-01  0:35                   ` H. Peter Anvin
2010-04-01  1:07                     ` Yinghai Lu
2010-04-01  2:02                     ` [PATCH -v3] nobootmem/bootmem, x86: Fix 32bit numa system without RAM on Node0 Yinghai Lu
2010-04-01  3:18                       ` H. Peter Anvin
2010-04-01  3:30                         ` Yinghai Lu
2010-04-01  3:44                         ` [PATCH -v4 1/2] nobootmem, " Yinghai Lu
2010-04-01  3:45                           ` Yinghai Lu [this message]
2010-04-01 22:57                             ` [tip:x86/urgent] bootmem, x86: Fix 32bit numa system without RAM on node 0 tip-bot for Yinghai Lu
2010-04-01 22:57                           ` [tip:x86/urgent] nobootmem, " tip-bot for Yinghai Lu
2010-03-31 10:51 ` Config NO_BOOTMEM breaks my amd64 box Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB416D7.6090203@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome