mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Rafi Rubin <rafi@seas.upenn.edu>
Cc: Michael Poole <mdpoole@troilus.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: mt: introduce MT event slots
Date: Fri, 09 Apr 2010 00:12:49 +0200	[thread overview]
Message-ID: <4BBE54E1.9020608@euromail.se> (raw)
In-Reply-To: <4BBE4969.60802@seas.upenn.edu>

Rafi Rubin wrote:
[...]

>>> Is there any particular downside to defaulting to implicit slot ids?
>> Yes. The device driver should not have to update every slot between
>> synchronizations, or the point would be lost.
>>
>>> For drivers/hardware that don't handle tracking, SYN_MT_REPORT could
>>> just result in dev->slot++ and a SYN_REPORT resets dev->slot to 0;
>> Drivers that do not handle tracking should not use the slots at all. The slot
>> concept requires that whatever gets communicated over it is identifiable, or
>> else it would not be possible to send changes. Drivers without tracking
>> capabilities should stick to the current MT protocol, for which it was designed.
> 
> That's unfortunate.
> 
> I think tracking upsets are generally quite rare (at least for the n-trig
> hardware), and we would see most of the benefit of jitter and bandwidth
> reduction even if we use contact ordering for slots.  Tracking upsets would
> still flow downstream, a large state change should cause the slot to emit the
> new position.
> 
> I was also hoping the slotting mechanism might be a good place to inject generic
> tracking support later.

But it is! It was not my intention to discourage the slot protocol for a driver
that *wants* to track contacts, only the ones that do not. As you already
guessed, there is a natural migration path towards using the slot extension and
kernel-provided software finger tracking.

Cheers,
Henrik


  reply	other threads:[~2010-04-08 22:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08  0:13 Henrik Rydberg
2010-04-08  3:07 ` Michael Poole
2010-04-08  9:43   ` Henrik Rydberg
2010-04-08 11:40     ` Michael Poole
2010-04-08 13:01       ` Henrik Rydberg
2010-04-16  7:40         ` Hennerich, Michael
2010-04-16 14:29           ` Henrik Rydberg
2010-04-08 19:15     ` Rafi Rubin
2010-04-08 20:25       ` Henrik Rydberg
2010-04-08 21:23         ` Rafi Rubin
2010-04-08 22:12           ` Henrik Rydberg [this message]
2010-04-15 23:25 ` Dmitry Torokhov
2010-04-16 15:09   ` Henrik Rydberg
2010-05-04  7:57   ` Henrik Rydberg
2010-05-04 17:29     ` Dmitry Torokhov
2010-05-04 21:41       ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBE54E1.9020608@euromail.se \
    --to=rydberg@euromail.se \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdpoole@troilus.org \
    --cc=rafi@seas.upenn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®