mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, h.mitake@gmail.com,
	Paul Mackerras <paulus@samba.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] Add "nested" field to event of lock_release
Date: Sat, 10 Apr 2010 23:50:26 +0900	[thread overview]
Message-ID: <4BC09032.1060004@dcl.info.waseda.ac.jp> (raw)
In-Reply-To: <1270907986.4222.2.camel@twins>

On 04/10/10 22:59, Peter Zijlstra wrote:
 > On Sat, 2010-04-10 at 19:41 +0900, Hitoshi Mitake wrote:
 >> State machine of perf lock requires "nested" field of lock_release(),
 >> so this patch adds it to event.
 >>
 >> Signed-off-by: Hitoshi Mitake<mitake@dcl.info.waseda.ac.jp>
 >> Cc: Peter Zijlstra<a.p.zijlstra@chello.nl>
 >> Cc: Paul Mackerras<paulus@samba.org>
 >> Cc: Arnaldo Carvalho de Melo<acme@redhat.com>
 >> Cc: Frederic Weisbecker<fweisbec@gmail.com>
 >
 > The nested flag only indicates if it could be nested, not if it was
 > actually nested. So no, this doesn't make any sense at all.
 >
 > (in fact, pretty much every lock_release out there has nested=1)
 >

Ah, sorry, I misunderstood.
When looked at rwlock_release(), I judged that nested is required,
because double or more read_lock() is allowed.

Thanks for your correction :)
        Hitoshi

  reply	other threads:[~2010-04-10 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-10 10:41 Hitoshi Mitake
2010-04-10 13:59 ` Peter Zijlstra
2010-04-10 14:50   ` Hitoshi Mitake [this message]
2010-04-10 17:45     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC09032.1060004@dcl.info.waseda.ac.jp \
    --to=mitake@dcl.info.waseda.ac.jp \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=h.mitake@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®