From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932846Ab0DQAYH (ORCPT ); Fri, 16 Apr 2010 20:24:07 -0400 Received: from mailservice.tudelft.nl ([130.161.131.5]:55514 "EHLO mailservice.tudelft.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932510Ab0DQAYA (ORCPT ); Fri, 16 Apr 2010 20:24:00 -0400 X-Spam-Flag: NO X-Spam-Score: -22.589 Message-ID: <4BC8FF9D.7050500@tremplin-utc.net> Date: Sat, 17 Apr 2010 02:23:57 +0200 From: =?UTF-8?B?w4lyaWMgUGllbA==?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.21) Gecko/20090319 Mandriva/2.0.0.21-1mdv2009.1 (2009.1) Thunderbird/2.0.0.21 Mnenhy/0.7.6.666 MIME-Version: 1.0 To: platform-driver-x86@vger.kernel.org, Andrew Morton CC: "Brown, Len" , Matthew Garrett , Linux Kernel Mailing List Subject: [PATCH 1/2] Make WMI be selected automatically when needed X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Many different modules depend on WMI. In Kconfig, some used to "depend" on it, while others "selected" it. As WMI by itself is useless and more like a library, it's easier for the user to have it automatically selected whenever needed. It's especially true for options in completely different places (like LEDS_DELL_NETBOOKS). So we consistently "select" it. Signed-off-by: Éric Piel --- drivers/leds/Kconfig | 3 ++- drivers/platform/x86/Kconfig | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 505eb64..71e8a51 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -280,7 +280,8 @@ config LEDS_ADP5520 config LEDS_DELL_NETBOOKS tristate "External LED on Dell Business Netbooks" - depends on X86 && ACPI_WMI + depends on X86 + select ACPI_WMI help This adds support for the Latitude 2100 and similar notebooks that have an external LED. diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 7bec458..9808ef3 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -89,8 +89,8 @@ config DELL_LAPTOP config DELL_WMI tristate "Dell WMI extras" - depends on ACPI_WMI depends on INPUT + select ACPI_WMI ---help--- Say Y here if you want to support WMI-based hotkeys on Dell laptops. @@ -136,9 +136,9 @@ config TC1100_WMI config HP_WMI tristate "HP WMI extras" - depends on ACPI_WMI depends on INPUT depends on RFKILL || RFKILL = n + select ACPI_WMI help Say Y here if you want to support WMI-based hotkeys on HP laptops and to read data from WMI such as docking or ambient light sensor state. @@ -387,9 +387,9 @@ config EEEPC_LAPTOP config EEEPC_WMI tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)" - depends on ACPI_WMI depends on INPUT depends on EXPERIMENTAL + select ACPI_WMI ---help--- Say Y here if you want to support WMI-based hotkeys on Eee PC laptops. @@ -419,9 +419,9 @@ config ACPI_WMI config MSI_WMI tristate "MSI WMI extras" - depends on ACPI_WMI depends on INPUT depends on BACKLIGHT_CLASS_DEVICE + select ACPI_WMI select INPUT_SPARSEKMAP help Say Y here if you want to support WMI-based hotkeys on MSI laptops. -- 1.7.0.5