From: "Éric Piel" <Eric.Piel@tremplin-utc.net>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed
Date: Fri, 23 Apr 2010 21:51:54 +0200 [thread overview]
Message-ID: <4BD1FA5A.6060406@tremplin-utc.net> (raw)
In-Reply-To: <20100423192059.GA32705@srcf.ucam.org>
Op 23-04-10 21:20, Matthew Garrett schreef:
> On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:
>
>> config LEDS_DELL_NETBOOKS
>> tristate "External LED on Dell Business Netbooks"
>> - depends on X86 && ACPI_WMI
>> + depends on X86
>> + depends on ACPI
>> + select ACPI_WMI
>
> I dislike this. The originally stated dependencies are correct and more
> accurately represent what the code requires, and changing that for the
> sake of making it easier for people to find the driver sounds like it's
> trying to cover up shortcomings in our configuration system more than
> anything else.
>
Currently there are 2 modules which select ACPI_WMI and 4 which depend
on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
many which depend on it. Making usage of the select functionality all
the time would avoid these inconsistencies.
Eric
next prev parent reply other threads:[~2010-04-23 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 0:23 Éric Piel
2010-04-17 0:31 ` Randy Dunlap
2010-04-17 0:58 ` Éric Piel
2010-04-23 19:20 ` Matthew Garrett
2010-04-23 19:51 ` Éric Piel [this message]
2010-04-23 20:04 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD1FA5A.6060406@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome