From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: tytso@mit.edu
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Documentation: -stable rules: upstream commit ID requirement reworded
Date: Sat, 24 Apr 2010 11:12:12 +0200 [thread overview]
Message-ID: <4BD2B5EC.4020808@s5r6.in-berlin.de> (raw)
In-Reply-To: <20100424020253.GP14986@thunk.org>
tytso@mit.edu wrote:
> On Thu, Apr 22, 2010 at 03:40:14PM -0700, Greg Kroah-Hartman wrote:
>> From: Stefan Richter <stefanr@s5r6.in-berlin.de>
>>
>> It is a hard requirement to include the upstream commit ID in the
>> changelog of a -stable submission, not just a courtesy to the stable
>> team. This concerns only mail submission though, which is no longer
>> the only way into stable. (Also, fix a double "the".)
>
> I find the upstream commit ID to be highly useful when looking at
> commits in the stable tree. So it would be nice IMHO if we could
> enforce this requirement regardless of whether the submission path is
> via e-mail or git.
In the semi-automatic submission path via git --- i.e. of commits which
feature a Cc: stable@kernel.org line in the changelog when they show up
in Linus' tree --- the upstream commit ID is not known to the submitter
at the time of submission. Apparently Greg's scripts modify the
changelogs respectively when he cherry-picks from linux-2.6.git, so the
requirement is also always fulfilled with this alternative submission path.
E.g. as in http://lkml.org/lkml/2010/4/22/294 which was apparently
submitted the semi-automatic way, via
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=44fef22416886a04d432043f741a6faf2c6ffefd
--
Stefan Richter
-=====-==-=- -=-- ==---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-04-24 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 22:29 [GIT PATCH] driver core fixes for 2.6.34-git Greg KH
2010-04-22 22:40 ` [PATCH 1/3] Documentation: -stable rules: upstream commit ID requirement reworded Greg Kroah-Hartman
2010-04-24 2:02 ` tytso
2010-04-24 9:12 ` Stefan Richter [this message]
2010-04-24 9:30 ` Stefan Richter
2010-04-24 15:02 ` Greg KH
2010-04-24 16:50 ` Theodore Tso
2010-04-22 22:40 ` [PATCH 2/3] Documentation/HOWTO: update git home URL Greg Kroah-Hartman
2010-04-22 22:40 ` [PATCH 3/3] sysfs: use sysfs_attr_init in ASUS atk0110 driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD2B5EC.4020808@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®