From: Eric Lescouet <Eric.Lescouet@VirtualLogix.com>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/2] USB: make hub.h, hcd.h public (drivers dependency), linux-2.6.34-rc5
Date: Sat, 24 Apr 2010 18:18:00 +0200 [thread overview]
Message-ID: <4BD319B8.1030508@VirtualLogix.com> (raw)
In-Reply-To: <20100424154951.GA11919@kroah.com>
On 04/24/2010 05:49 PM, Greg KH wrote:
> On Sat, Apr 24, 2010 at 08:35:01AM -0700, Greg KH wrote:
>> On Sat, Apr 24, 2010 at 05:08:33PM +0200, Eric Lescouet wrote:
>>> The usbcore headers:hcd.h and hub.h are shared between usbcore,
>>> HCDs and a couple of other drivers (e.g. USBIP modules).
>>> So, it makes sense to move them into a more public location and
>>> to cleanup dependency of those modules on kernel internal headers.
>>> Both are moved into include/linux/usb/
>>
>> Just move one at a time. Patches should do one thing only. So this
>> should be at least 2 patches.
>>
>> And I thought you were going to rename hub.h to ch11.h instead?
>
> Oops, I now see patch 2 :)
>
> Anyway, how about 3 patches here? Your last one is fine, but make the
> first one into 2 different ones? One that does hcd.h and then one that
> does hub.h.
Why not... ;-)
Since I'll do it again, I could use 2.6.34-rc5-git5, as per your request.
I was not so sure how to get the full source for the snapshot...
Should I apply 2.6.34-rc5-git5 patch onto 2.6.34-rc5 tree ?
Thanks,
Eric.
next prev parent reply other threads:[~2010-04-24 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-24 15:08 Eric Lescouet
2010-04-24 15:35 ` Greg KH
2010-04-24 15:49 ` Greg KH
2010-04-24 16:18 ` Eric Lescouet [this message]
2010-04-24 16:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD319B8.1030508@VirtualLogix.com \
--to=eric.lescouet@virtuallogix.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®