From: Bryan Wu <bryan.wu@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: s.hauer@pengutronix.de, gerg@uclinux.org,
amit.kucheria@canonical.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] netdev/fec: fix performance impact from mdio poll operation
Date: Fri, 28 May 2010 13:23:30 +0800 [thread overview]
Message-ID: <4BFF5352.8080104@canonical.com> (raw)
In-Reply-To: <20100516.002818.133869940.davem@davemloft.net>
On 05/16/2010 03:28 PM, David Miller wrote:
> From: Bryan Wu <bryan.wu@canonical.com>
> Date: Fri, 7 May 2010 10:27:18 +0800
>
>> BugLink: http://bugs.launchpad.net/bugs/546649
>> BugLink: http://bugs.launchpad.net/bugs/457878
>>
>> After introducing phylib supporting, users experienced performace drop. That is
>> because of the mdio polling operation of phylib. Use msleep to replace the busy
>> waiting cpu_relax() and remove the warning message.
>>
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>> Acked-by: Andy Whitcroft <apw@canonical.com>
>
> As you've already been told, making these MDIO interfaces fail silently
> is not acceptable.
>
> Please fix this bug properly and resubmit this patch series.
>
So sorry for the delay. My board's broken for several weeks. After I got a new,
I will try to fix this and resubmit this patch.
Thanks
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
next prev parent reply other threads:[~2010-05-28 5:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:27 [PATCH 0/2] net-next/fec: bug fixing after introduced phylib supporting Bryan Wu
2010-05-07 2:27 ` [PATCH 1/2] netdev/fec: fix performance impact from mdio poll operation Bryan Wu
2010-05-07 16:06 ` Andy Fleming
2010-05-08 10:07 ` Bryan Wu
2010-05-08 15:25 ` Andy Fleming
2010-05-16 7:28 ` David Miller
2010-05-28 5:23 ` Bryan Wu [this message]
2010-05-07 2:27 ` [PATCH 2/2] netdev/fec: fix ifconfig eth0 down hang issue Bryan Wu
2010-05-28 5:26 ` Bryan Wu
2010-05-28 7:48 ` David Miller
2010-05-28 8:03 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFF5352.8080104@canonical.com \
--to=bryan.wu@canonical.com \
--cc=amit.kucheria@canonical.com \
--cc=davem@davemloft.net \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome