From: Bryan Wu <bryan.wu@canonical.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: davem@davemloft.net, afleming@gmail.com, s.hauer@pengutronix.de,
gerg@uclinux.org, amit.kucheria@canonical.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netdev/fec: fix ifconfig eth0 down hang issue
Date: Fri, 28 May 2010 23:13:48 +0800 [thread overview]
Message-ID: <4BFFDDAC.7000909@canonical.com> (raw)
In-Reply-To: <20100528144506.GB13777@pengutronix.de>
On 05/28/2010 10:45 PM, Wolfram Sang wrote:
> On Fri, May 28, 2010 at 05:08:05PM +0800, Bryan Wu wrote:
>> BugLink: http://bugs.launchpad.net/bugs/559065
>>
>> In fec open/close function, we need to use phy_connect and phy_disconnect
>> operation before we start/stop phy. Otherwise it will cause system hang.
>>
>> Only call fec_enet_mii_probe() in open function, because the first open
>> action will cause NULL pointer error.
>>
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>
> We use this patch for 1 month now and didn't encounter any flaws so far.
>
> Tested-by: Wolfram Sang <w.sang@pengutronix.de>
>
> Oops, too late... well, one for the comfortable feeling ;)
>
Thanks a lot, Wolfram. You are real helpful here.
Because my babbage board has broken for several weeks, I don't have hardware to
test my FEC patches.
The performance drop issue still hangs in my brain. As soon as I have a new
patch, could you please help to test? Or do you guys found any performance drop
solution on your hardware? IIRC, you reported similar issue as us.
Best regards,
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
next prev parent reply other threads:[~2010-05-28 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 9:08 Bryan Wu
2010-05-28 10:40 ` David Miller
2010-05-28 14:45 ` Wolfram Sang
2010-05-28 15:13 ` Bryan Wu [this message]
2010-05-29 0:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFFDDAC.7000909@canonical.com \
--to=bryan.wu@canonical.com \
--cc=afleming@gmail.com \
--cc=amit.kucheria@canonical.com \
--cc=davem@davemloft.net \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®