mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Don Zickus <dzickus@redhat.com>
Cc: sam@ravnborg.org, agruen@suse.de, linux-kernel@vger.kernel.org
Subject: Re: Makefile.build: make KBUILD_SYMTYPES work again
Date: Fri, 04 Jun 2010 15:28:30 +0200	[thread overview]
Message-ID: <4C08FF7E.8040806@suse.cz> (raw)
In-Reply-To: <1274735244-31249-1-git-send-email-dzickus@redhat.com>

On 24.5.2010 23:07, Don Zickus wrote:
> commit 37a8d9f67f18de1e2cbc7387311ce22d4dbff518 tried to combine some
> duplicate code and accidentally broke how KBUILD_SYMTYPES worked
> 
> This fixes the code to match the original intention by the author who
> originally added the code I believe.
> 
> The fixes include:
> - removing extra whitespaces in the if-statements
> - moving the if-statement from around the -r to the -T
> - adding a second arg to cmd_gensymtypes to simplify the options passed
>   to genksyms.
> 
> Tested by instrumenting genksyms and seeing what options were passed in
> during a make, KBUILD_SYMTYPES make, and when a foo.symref was created.
> 
> Everything compiled and looked ok.
> 
> Signed-off-by: Don Zickus <dzickus@redhat.com>

Thanks. I wrote a very similar patch last year which I thought to have
sent to Sam, but it seems that I haven't (and since then I forgot about
it). Applied now.

Michal

      reply	other threads:[~2010-06-04 13:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 21:07 Don Zickus
2010-06-04 13:28 ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C08FF7E.8040806@suse.cz \
    --to=mmarek@suse.cz \
    --cc=agruen@suse.de \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome